-
Notifications
You must be signed in to change notification settings - Fork 474
chore(llmobs): fix type error for crew ai latest version #13500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 235 ± 3 ms. The average import time from base is: 238 ± 3 ms. The import time difference between this PR and base is: -2.4 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-05-27 15:38:09 Comparing candidate commit 08ee801 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 460 metrics, 8 unstable metrics. scenario:iast_aspects-ospathbasename_aspect
scenario:iast_aspects-ospathdirname_aspect
scenario:iast_aspects-ospathsplit_aspect
scenario:iast_aspects-strip_aspect
|
Yun-Kim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can add a quick repro case that would be great, but otherwise lgtm!
Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
…nto evan.li/crewai-fix
|
closing for #13511 |
Fixes a
TypeErrorwith crewai>=1.121.0 caused by crew ai supporting empty contextAlso updates the crewai version we test with to be a min compatible version with 1.121.0
Checklist
Reviewer Checklist