Skip to content

Conversation

@lievan
Copy link
Contributor

@lievan lievan commented May 23, 2025

Fixes a TypeError with crewai>=1.121.0 caused by crew ai supporting empty context

Also updates the crewai version we test with to be a min compatible version with 1.121.0

image

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

CODEOWNERS have been resolved as:

.riot/requirements/158ac30.txt                                          @DataDog/apm-python
.riot/requirements/16628a6.txt                                          @DataDog/apm-python
.riot/requirements/181e571.txt                                          @DataDog/apm-python
.riot/requirements/321c69b.txt                                          @DataDog/apm-python
.riot/requirements/8b0105d.txt                                          @DataDog/apm-python
.riot/requirements/f27aa11.txt                                          @DataDog/apm-python
releasenotes/notes/crewai-fix-8d66e3489f87d046.yaml                     @DataDog/apm-python
.riot/requirements/14e7a10.txt                                          @DataDog/apm-python
.riot/requirements/1538bcb.txt                                          @DataDog/apm-python
.riot/requirements/1f24364.txt                                          @DataDog/apm-python
.riot/requirements/213dcfe.txt                                          @DataDog/apm-python
.riot/requirements/55abc5e.txt                                          @DataDog/apm-python
ddtrace/llmobs/_integrations/crewai.py                                  @DataDog/ml-observability
lib-injection/sources/min_compatible_versions.csv                       @DataDog/apm-core-python
min_compatible_versions.csv                                             @DataDog/apm-core-python
riotfile.py                                                             @DataDog/apm-python

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 235 ± 3 ms.

The average import time from base is: 238 ± 3 ms.

The import time difference between this PR and base is: -2.4 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.001 ms (0.85%)
ddtrace.bootstrap.sitecustomize 1.324 ms (0.56%)
ddtrace.bootstrap.preload 1.324 ms (0.56%)
ddtrace.internal.remoteconfig.client 0.649 ms (0.28%)
ddtrace 0.677 ms (0.29%)
ddtrace.internal._unpatched 0.024 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented May 23, 2025

Benchmarks

Benchmark execution time: 2025-05-27 15:38:09

Comparing candidate commit 08ee801 in PR branch evan.li/crewai-fix with baseline commit 0d1b115 in branch main.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 460 metrics, 8 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟥 execution_time [+466.508ns; +707.934ns] or [+11.242%; +17.060%]

scenario:iast_aspects-ospathdirname_aspect

  • 🟥 execution_time [+1.045µs; +1.205µs] or [+22.705%; +26.182%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟥 execution_time [+748.445ns; +947.492ns] or [+15.536%; +19.668%]

scenario:iast_aspects-strip_aspect

  • 🟥 execution_time [+1.515µs; +1.622µs] or [+11.513%; +12.323%]

@lievan lievan marked this pull request as ready for review May 27, 2025 13:30
@lievan lievan requested review from a team as code owners May 27, 2025 13:30
Copy link
Contributor

@Yun-Kim Yun-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can add a quick repro case that would be great, but otherwise lgtm!

lievan and others added 5 commits May 27, 2025 10:14
@lievan lievan requested a review from a team as a code owner May 27, 2025 14:30
@lievan lievan requested a review from erikayasuda May 27, 2025 14:30
@lievan
Copy link
Contributor Author

lievan commented May 27, 2025

closing for #13511

@lievan lievan closed this May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants