Conversation
Codeowners resolved as |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f0b74ed20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
brettlangdon
left a comment
There was a problem hiding this comment.
What does riot list look like?
It might be an issue with how the riot venvs are defined and not with how the we resolve them here in this script. (e.g. this might be happening in CI as well)
Performance SLOsComparing candidate core-analysis (5f1d07f) with baseline main (647a119) 📈 Performance Regressions (4 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 106.432µs (SLO: <130.000µs 📉 -18.1%) vs baseline: +4.8% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ add_inplace_aspectTime: ✅ 102.088µs (SLO: <130.000µs 📉 -21.5%) vs baseline: +0.5% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ add_inplace_noaspectTime: ✅ 28.295µs (SLO: <40.000µs 📉 -29.3%) vs baseline: +0.3% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ add_noaspectTime: ✅ 48.916µs (SLO: <70.000µs 📉 -30.1%) vs baseline: -0.3% Memory: ✅ 43.214MB (SLO: <46.000MB -6.1%) vs baseline: +5.5% ✅ bytearray_aspectTime: ✅ 251.400µs (SLO: <400.000µs 📉 -37.2%) vs baseline: -0.2% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ bytearray_extend_aspectTime: ✅ 645.476µs (SLO: <800.000µs 📉 -19.3%) vs baseline: +1.8% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 268.554µs (SLO: <400.000µs 📉 -32.9%) vs baseline: +1.4% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.8% ✅ bytearray_noaspectTime: ✅ 140.490µs (SLO: <300.000µs 📉 -53.2%) vs baseline: +3.2% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ bytes_aspectTime: ✅ 221.559µs (SLO: <300.000µs 📉 -26.1%) vs baseline: +2.2% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 134.424µs (SLO: <200.000µs 📉 -32.8%) vs baseline: -0.6% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 3.879ms (SLO: <5.000ms 📉 -22.4%) vs baseline: +0.5% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 322.424µs (SLO: <420.000µs 📉 -23.2%) vs baseline: +2.0% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 89.156µs (SLO: <300.000µs 📉 -70.3%) vs baseline: +1.8% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ capitalize_noaspectTime: ✅ 259.311µs (SLO: <300.000µs 📉 -13.6%) vs baseline: +2.3% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ casefold_aspectTime: ✅ 89.043µs (SLO: <500.000µs 📉 -82.2%) vs baseline: +1.1% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.4% ✅ casefold_noaspectTime: ✅ 311.661µs (SLO: <500.000µs 📉 -37.7%) vs baseline: +0.2% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ decode_aspectTime: ✅ 87.047µs (SLO: <100.000µs 📉 -13.0%) vs baseline: +0.1% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.1% ✅ decode_noaspectTime: ✅ 154.199µs (SLO: <210.000µs 📉 -26.6%) vs baseline: +1.4% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 85.044µs (SLO: <200.000µs 📉 -57.5%) vs baseline: +0.3% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ encode_noaspectTime: ✅ 142.374µs (SLO: <200.000µs 📉 -28.8%) vs baseline: +3.1% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ format_aspectTime: ✅ 14.685ms (SLO: <19.200ms 📉 -23.5%) vs baseline: +0.1% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 16.462ms (SLO: <21.500ms 📉 -23.4%) vs baseline: -0.2% Memory: ✅ 43.155MB (SLO: <46.000MB -6.2%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 374.448µs (SLO: <500.000µs 📉 -25.1%) vs baseline: +0.2% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ format_noaspectTime: ✅ 304.353µs (SLO: <500.000µs 📉 -39.1%) vs baseline: +0.5% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ index_aspectTime: ✅ 125.370µs (SLO: <300.000µs 📉 -58.2%) vs baseline: +1.0% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ index_noaspectTime: ✅ 40.107µs (SLO: <300.000µs 📉 -86.6%) vs baseline: ~same Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +5.3% ✅ join_aspectTime: ✅ 212.372µs (SLO: <300.000µs 📉 -29.2%) vs baseline: -2.1% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.8% ✅ join_noaspectTime: ✅ 140.295µs (SLO: <300.000µs 📉 -53.2%) vs baseline: -2.5% Memory: ✅ 43.175MB (SLO: <46.000MB -6.1%) vs baseline: +5.2% ✅ ljust_aspectTime: ✅ 604.595µs (SLO: <700.000µs 📉 -13.6%) vs baseline: 📈 +21.3% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 259.172µs (SLO: <300.000µs 📉 -13.6%) vs baseline: +2.8% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ lower_aspectTime: ✅ 296.590µs (SLO: <500.000µs 📉 -40.7%) vs baseline: +0.4% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ lower_noaspectTime: ✅ 236.262µs (SLO: <300.000µs 📉 -21.2%) vs baseline: +1.0% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.2% ✅ lstrip_aspectTime: ✅ 0.279ms (SLO: <3.000ms 📉 -90.7%) vs baseline: -0.3% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.1% ✅ lstrip_noaspectTime: ✅ 0.178ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -1.9% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.1% ✅ modulo_aspectTime: ✅ 14.345ms (SLO: <18.750ms 📉 -23.5%) vs baseline: -0.1% Memory: ✅ 43.214MB (SLO: <46.000MB -6.1%) vs baseline: +5.3% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.820ms (SLO: <19.350ms 📉 -23.4%) vs baseline: +0.1% Memory: ✅ 43.136MB (SLO: <46.000MB -6.2%) vs baseline: +4.7% ✅ modulo_aspect_for_bytesTime: ✅ 14.438ms (SLO: <18.900ms 📉 -23.6%) vs baseline: ~same Memory: ✅ 43.175MB (SLO: <46.000MB -6.1%) vs baseline: +5.0% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.653ms (SLO: <19.150ms 📉 -23.5%) vs baseline: ~same Memory: ✅ 43.195MB (SLO: <46.000MB -6.1%) vs baseline: +5.1% ✅ modulo_noaspectTime: ✅ 0.359ms (SLO: <3.000ms 📉 -88.0%) vs baseline: +1.0% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 18.383ms (SLO: <24.000ms 📉 -23.4%) vs baseline: -0.4% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.1% ✅ replace_noaspectTime: ✅ 282.406µs (SLO: <300.000µs -5.9%) vs baseline: -0.7% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 314.224µs (SLO: <420.000µs 📉 -25.2%) vs baseline: -1.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ repr_noaspectTime: ✅ 46.867µs (SLO: <90.000µs 📉 -47.9%) vs baseline: -0.3% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ rstrip_aspectTime: ✅ 389.943µs (SLO: <500.000µs 📉 -22.0%) vs baseline: -1.0% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 185.918µs (SLO: <300.000µs 📉 -38.0%) vs baseline: +2.3% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.2% ✅ slice_aspectTime: ✅ 183.954µs (SLO: <300.000µs 📉 -38.7%) vs baseline: -2.3% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.0% ✅ slice_noaspectTime: ✅ 54.377µs (SLO: <90.000µs 📉 -39.6%) vs baseline: -0.2% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +5.1% ✅ stringio_aspectTime: ✅ 4.531ms (SLO: <5.000ms -9.4%) vs baseline: 📈 +16.6% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 357.401µs (SLO: <500.000µs 📉 -28.5%) vs baseline: +2.7% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ strip_aspectTime: ✅ 278.368µs (SLO: <350.000µs 📉 -20.5%) vs baseline: -0.2% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 178.683µs (SLO: <240.000µs 📉 -25.5%) vs baseline: -1.7% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.9% ✅ swapcase_aspectTime: ✅ 340.004µs (SLO: <500.000µs 📉 -32.0%) vs baseline: +2.2% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 276.997µs (SLO: <400.000µs 📉 -30.8%) vs baseline: +1.1% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 325.474µs (SLO: <500.000µs 📉 -34.9%) vs baseline: +0.9% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ title_noaspectTime: ✅ 262.074µs (SLO: <400.000µs 📉 -34.5%) vs baseline: +1.6% Memory: ✅ 43.096MB (SLO: <46.000MB -6.3%) vs baseline: +5.1% ✅ translate_aspectTime: ✅ 501.719µs (SLO: <700.000µs 📉 -28.3%) vs baseline: +3.1% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 427.632µs (SLO: <500.000µs 📉 -14.5%) vs baseline: +0.6% Memory: ✅ 42.979MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ upper_aspectTime: ✅ 295.036µs (SLO: <500.000µs 📉 -41.0%) vs baseline: +0.6% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 236.736µs (SLO: <400.000µs 📉 -40.8%) vs baseline: +2.1% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 503.910µs (SLO: <700.000µs 📉 -28.0%) vs baseline: 📈 +17.7% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ ospathbasename_noaspectTime: ✅ 429.926µs (SLO: <700.000µs 📉 -38.6%) vs baseline: -1.4% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 619.186µs (SLO: <700.000µs 📉 -11.5%) vs baseline: -0.7% Memory: ✅ 43.116MB (SLO: <46.000MB -6.3%) vs baseline: +5.7% ✅ ospathjoin_noaspectTime: ✅ 619.956µs (SLO: <700.000µs 📉 -11.4%) vs baseline: -1.4% Memory: ✅ 43.037MB (SLO: <46.000MB -6.4%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 352.725µs (SLO: <700.000µs 📉 -49.6%) vs baseline: -1.8% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 359.750µs (SLO: <700.000µs 📉 -48.6%) vs baseline: -1.6% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 491.833µs (SLO: <700.000µs 📉 -29.7%) vs baseline: +0.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +4.7% ✅ ospathsplit_noaspectTime: ✅ 497.555µs (SLO: <700.000µs 📉 -28.9%) vs baseline: -0.3% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +4.8% ✅ ospathsplitdrive_aspectTime: ✅ 373.063µs (SLO: <700.000µs 📉 -46.7%) vs baseline: -1.3% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.6% ✅ ospathsplitdrive_noaspectTime: ✅ 72.777µs (SLO: <700.000µs 📉 -89.6%) vs baseline: +0.2% Memory: ✅ 42.920MB (SLO: <46.000MB -6.7%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 462.011µs (SLO: <700.000µs 📉 -34.0%) vs baseline: +0.1% Memory: ✅ 42.939MB (SLO: <46.000MB -6.7%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 464.816µs (SLO: <700.000µs 📉 -33.6%) vs baseline: -0.9% Memory: ✅ 42.998MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% 📈 iastaspectssplit - 12/12✅ rsplit_aspectTime: ✅ 166.539µs (SLO: <250.000µs 📉 -33.4%) vs baseline: 📈 +12.3% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.3% ✅ rsplit_noaspectTime: ✅ 168.819µs (SLO: <250.000µs 📉 -32.5%) vs baseline: 📈 +11.6% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.3% ✅ split_aspectTime: ✅ 151.079µs (SLO: <250.000µs 📉 -39.6%) vs baseline: +4.1% Memory: ✅ 43.077MB (SLO: <46.000MB -6.4%) vs baseline: +5.1% ✅ split_noaspectTime: ✅ 164.526µs (SLO: <250.000µs 📉 -34.2%) vs baseline: +9.9% Memory: ✅ 43.018MB (SLO: <46.000MB -6.5%) vs baseline: +5.0% ✅ splitlines_aspectTime: ✅ 150.432µs (SLO: <250.000µs 📉 -39.8%) vs baseline: +2.9% Memory: ✅ 42.959MB (SLO: <46.000MB -6.6%) vs baseline: +5.8% ✅ splitlines_noaspectTime: ✅ 160.687µs (SLO: <250.000µs 📉 -35.7%) vs baseline: +7.1% Memory: ✅ 43.057MB (SLO: <46.000MB -6.4%) vs baseline: +5.3% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.482µs (SLO: <20.000µs 📉 -82.6%) vs baseline: 📈 +21.9% Memory: ✅ 35.665MB (SLO: <38.000MB -6.1%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 204.162µs (SLO: <220.000µs -7.2%) vs baseline: +2.9% Memory: ✅ 35.665MB (SLO: <38.000MB -6.1%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.346µs (SLO: <20.000µs 📉 -83.3%) vs baseline: +3.8% Memory: ✅ 35.665MB (SLO: <38.000MB -6.1%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.183µs (SLO: <230.000µs -5.6%) vs baseline: +2.0% Memory: ✅ 35.625MB (SLO: <38.000MB -6.2%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.185µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.5% Memory: ✅ 35.527MB (SLO: <38.000MB -6.5%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.586µs (SLO: <150.000µs -9.6%) vs baseline: -1.2% Memory: ✅ 35.665MB (SLO: <38.000MB -6.1%) vs baseline: +5.1% ✅ 1-rate-metric-1-timesTime: ✅ 3.148µs (SLO: <20.000µs 📉 -84.3%) vs baseline: +5.2% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 218.088µs (SLO: <250.000µs 📉 -12.8%) vs baseline: +3.2% Memory: ✅ 35.507MB (SLO: <38.000MB -6.6%) vs baseline: +4.6% ✅ 100-count-metrics-100-timesTime: ✅ 20.411ms (SLO: <22.000ms -7.2%) vs baseline: +1.7% Memory: ✅ 35.606MB (SLO: <38.000MB -6.3%) vs baseline: +5.0% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.292ms (SLO: <2.550ms 📉 -10.1%) vs baseline: +3.0% Memory: ✅ 35.606MB (SLO: <38.000MB -6.3%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.391ms (SLO: <1.550ms 📉 -10.2%) vs baseline: -0.9% Memory: ✅ 35.684MB (SLO: <38.000MB -6.1%) vs baseline: +5.3% ✅ 100-rate-metrics-100-timesTime: ✅ 2.222ms (SLO: <2.550ms 📉 -12.8%) vs baseline: +1.9% Memory: ✅ 35.704MB (SLO: <38.000MB -6.0%) vs baseline: +5.2% ✅ flush-1-metricTime: ✅ 4.526µs (SLO: <20.000µs 📉 -77.4%) vs baseline: +1.9% Memory: ✅ 35.547MB (SLO: <38.000MB -6.5%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 173.817µs (SLO: <250.000µs 📉 -30.5%) vs baseline: -0.6% Memory: ✅ 35.684MB (SLO: <38.000MB -6.1%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.184ms (SLO: <2.500ms 📉 -12.6%) vs baseline: +0.2% Memory: ✅ 36.412MB (SLO: <38.750MB -6.0%) vs baseline: +4.9% 🟡 Near SLO Breach (1 suite)🟡 otelsdkspan - 24/24✅ add-eventTime: ✅ 40.493ms (SLO: <42.000ms -3.6%) vs baseline: -0.8% Memory: ✅ 38.044MB (SLO: <40.750MB -6.6%) vs baseline: +5.0% ✅ add-linkTime: ✅ 36.346ms (SLO: <38.550ms -5.7%) vs baseline: -0.7% Memory: ✅ 38.122MB (SLO: <40.750MB -6.4%) vs baseline: +5.2% ✅ add-metricsTime: ✅ 219.059ms (SLO: <232.000ms -5.6%) vs baseline: +0.2% Memory: ✅ 38.142MB (SLO: <40.750MB -6.4%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 213.412ms (SLO: <221.600ms -3.7%) vs baseline: +1.4% Memory: ✅ 38.044MB (SLO: <40.750MB -6.6%) vs baseline: +5.1% ✅ get-contextTime: ✅ 29.215ms (SLO: <31.300ms -6.7%) vs baseline: ~same Memory: ✅ 38.142MB (SLO: <40.750MB -6.4%) vs baseline: +5.4% ✅ is-recordingTime: ✅ 29.405ms (SLO: <31.000ms -5.1%) vs baseline: +0.9% Memory: ✅ 38.122MB (SLO: <40.750MB -6.4%) vs baseline: +5.0% ✅ record-exceptionTime: ✅ 63.522ms (SLO: <65.850ms -3.5%) vs baseline: +0.1% Memory: ✅ 38.083MB (SLO: <40.750MB -6.5%) vs baseline: +5.2% ✅ set-statusTime: ✅ 31.930ms (SLO: <34.150ms -6.5%) vs baseline: +0.2% Memory: ✅ 38.122MB (SLO: <40.750MB -6.4%) vs baseline: +5.1% ✅ startTime: ✅ 29.578ms (SLO: <30.150ms 🟡 -1.9%) vs baseline: +2.2% Memory: ✅ 38.142MB (SLO: <40.750MB -6.4%) vs baseline: +5.4% ✅ start-finishTime: ✅ 34.112ms (SLO: <35.350ms -3.5%) vs baseline: +0.4% Memory: ✅ 38.221MB (SLO: <40.750MB -6.2%) vs baseline: +5.2% ✅ start-finish-telemetryTime: ✅ 34.187ms (SLO: <35.450ms -3.6%) vs baseline: +0.5% Memory: ✅ 38.063MB (SLO: <40.750MB -6.6%) vs baseline: +4.9% ✅ update-nameTime: ✅ 31.293ms (SLO: <33.400ms -6.3%) vs baseline: +0.6% Memory: ✅ 38.103MB (SLO: <40.750MB -6.5%) vs baseline: +5.0%
|
|
This is riot's expected behavior when environment variable arrays are defined (e.g., PYTHONMALLOC: [malloc, pymalloc, malloc_debug, pymalloc_debug]) - riot intentionally creates multiple instances sharing the same hash since the hash only reflects Python version and dependencies, not env vars. CI is not affected because it uses |
|
@taegyunkim ah, right... should we fix that in riot? |
|
@brettlangdon oh probably yes? Good point. |
Description
When running
profiling-memallocvenv even with--venv <hash>, it resulted running the venv 16 times (4 * 4 different PYTHONMALLOC env var values).It should run the venv 4 times each with 4 different PYTHONMALLOC env vars.
Testing
Risks
Additional Notes