Skip to content

ci(serverless): [DO NOT MERGE] validate lambda-python linkage fix#17856

Open
purple4reina wants to merge 1 commit intomainfrom
rey.abolofia/fix-lambda-tests
Open

ci(serverless): [DO NOT MERGE] validate lambda-python linkage fix#17856
purple4reina wants to merge 1 commit intomainfrom
rey.abolofia/fix-lambda-tests

Conversation

@purple4reina
Copy link
Copy Markdown
Contributor

⚠️ DO NOT MERGE

Temporary PR. Will be closed without merging once we've confirmed the linkage fix in DataDog/datadog-lambda-python#813 actually pulls this PR's ddtrace wheel into lambda-python's unit-test job.

Summary

Points the serverless lambda tests trigger at the lambda-python PR branch (rey.abolofia/fix-ddtrace-pr) instead of main. With that change, this PR's CI:

  1. Builds + uploads serverless wheels (upload serverless job, unchanged).
  2. Triggers lambda-python's PR pipeline with UPSTREAM_PIPELINE_ID = $CI_PIPELINE_ID.
  3. Lambda-python's PR has the new scripts/setup_python_env.sh which rewrites pyproject.toml's ddtrace dep to point at the wheel uploaded in step 1, then runs pip install .[dev] and pytest -vv against it.

If the linkage is wired correctly, the unit-test job's logs should print ddtrace version: <dev-shape string> from the diagnostic line in setup_python_env.sh.

Background

dd-trace-py's serverless lambda tests job triggers lambda-python on every dd-trace-py PR with UPSTREAM_PIPELINE_ID set, but lambda-python's unit-test job was running pip install .[dev] against the released ddtrace — so dd-trace-py PRs that broke lambda-python imports went undetected. That's how v4.8.0 shipped and required emergency hotfix lambda-python#811 (fix: pin ddtrace to <4.8.0 to avoid import errors). DataDog/datadog-lambda-python#813 fixes the unit-test side; this PR validates the round-trip.

Test plan

  • Push triggers dd-trace-py CI; serverless lambda tests job dispatches lambda-python's rey.abolofia/fix-ddtrace-pr pipeline.
  • In the dispatched lambda-python pipeline, inspect a unit-test (pythonXY-amd64) job log and confirm:
    • Replacing ddtrace dep with: ddtrace_serverless = { file = "..." } line is present.
    • ddtrace version: <dev-shape> line is present (suffixed with .dev/.post/+sha, not a clean release tag).
    • pytest -vv runs against the swapped ddtrace and passes.
  • Close this PR without merging once the above is confirmed; lambda-python#813 is the real fix.

🤖 Generated with Claude Code

Temporary change to validate the linkage fix in
DataDog/datadog-lambda-python#813. Triggers lambda-python's PR branch
instead of main so this PR's CI exercises the new setup_python_env.sh
that fetches the PR's ddtrace wheel via UPSTREAM_PIPELINE_ID.

Revert to `branch: main` before merging this PR — or close without
merging once the linkage is confirmed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@purple4reina purple4reina requested review from a team as code owners May 1, 2026 21:11
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b11b51792

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .gitlab-ci.yml
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 1, 2026

Benchmarks

Benchmark execution time: 2026-05-01 21:37:42

Comparing candidate commit 7b11b51 in PR branch rey.abolofia/fix-lambda-tests with baseline commit 89ae66b in branch main.

Found 0 performance improvements and 7 performance regressions! Performance is the same for 594 metrics, 4 unstable metrics.

scenario:iastaspects-add_aspect

  • 🟥 execution_time [+7.224µs; +9.367µs] or [+7.158%; +9.281%]

scenario:iastaspects-stringio_aspect

  • 🟥 execution_time [+467.358µs; +513.755µs] or [+11.956%; +13.143%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+74.562µs; +85.406µs] or [+17.068%; +19.550%]

scenario:recursivecomputation-medium

  • 🟥 max_rss_usage [+7.272MB; +7.434MB] or [+19.822%; +20.264%]

scenario:recursivecomputation-shallow

  • 🟥 max_rss_usage [+7.263MB; +7.483MB] or [+19.807%; +20.407%]

scenario:span-start

  • 🟥 execution_time [+1.247ms; +1.405ms] or [+7.015%; +7.906%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+185.119ns; +220.635ns] or [+8.806%; +10.496%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant