ci(serverless): [DO NOT MERGE] validate lambda-python linkage fix#17856
Open
purple4reina wants to merge 1 commit intomainfrom
Open
ci(serverless): [DO NOT MERGE] validate lambda-python linkage fix#17856purple4reina wants to merge 1 commit intomainfrom
purple4reina wants to merge 1 commit intomainfrom
Conversation
Temporary change to validate the linkage fix in DataDog/datadog-lambda-python#813. Triggers lambda-python's PR branch instead of main so this PR's CI exercises the new setup_python_env.sh that fetches the PR's ddtrace wheel via UPSTREAM_PIPELINE_ID. Revert to `branch: main` before merging this PR — or close without merging once the linkage is confirmed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b11b51792
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
BenchmarksBenchmark execution time: 2026-05-01 21:37:42 Comparing candidate commit 7b11b51 in PR branch Found 0 performance improvements and 7 performance regressions! Performance is the same for 594 metrics, 4 unstable metrics. scenario:iastaspects-add_aspect
scenario:iastaspects-stringio_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:recursivecomputation-medium
scenario:recursivecomputation-shallow
scenario:span-start
scenario:telemetryaddmetric-1-count-metric-1-times
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Points the
serverless lambda teststrigger at the lambda-python PR branch (rey.abolofia/fix-ddtrace-pr) instead ofmain. With that change, this PR's CI:upload serverlessjob, unchanged).UPSTREAM_PIPELINE_ID = $CI_PIPELINE_ID.scripts/setup_python_env.shwhich rewritespyproject.toml's ddtrace dep to point at the wheel uploaded in step 1, then runspip install .[dev]andpytest -vvagainst it.If the linkage is wired correctly, the unit-test job's logs should print
ddtrace version: <dev-shape string>from the diagnostic line insetup_python_env.sh.Background
dd-trace-py's
serverless lambda testsjob triggers lambda-python on every dd-trace-py PR withUPSTREAM_PIPELINE_IDset, but lambda-python'sunit-testjob was runningpip install .[dev]against the released ddtrace — so dd-trace-py PRs that broke lambda-python imports went undetected. That's how v4.8.0 shipped and required emergency hotfix lambda-python#811 (fix: pin ddtrace to <4.8.0 to avoid import errors). DataDog/datadog-lambda-python#813 fixes the unit-test side; this PR validates the round-trip.Test plan
serverless lambda testsjob dispatches lambda-python'srey.abolofia/fix-ddtrace-prpipeline.unit-test (pythonXY-amd64)job log and confirm:Replacing ddtrace dep with: ddtrace_serverless = { file = "..." }line is present.ddtrace version: <dev-shape>line is present (suffixed with.dev/.post/+sha, not a clean release tag).pytest -vvruns against the swapped ddtrace and passes.🤖 Generated with Claude Code