fix(profiling): restart the profiler on uwsgi fork (bp #2295) #2302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In uWSGI, the current code starts in the forked process the ProfilerInstance that has been created in the master process. That actually works fine, except all Events are discarded by the Recorder because its `pid` attribute is not updated: it is still the pid of the master process. Using the `_restart_on_fork` method makes sure that the `ProfilerInstance` gets a new `Recorder` object with the correct PID. The test is updated to not test only for file presence, but making sure that there is at least one sample included. This removes test_call_script_pprof_output_interval as it is flaky by construction and fails with the new extended test. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ea5992b)
Kyle-Verhoog
approved these changes
Apr 22, 2021
majorgreys
approved these changes
Apr 22, 2021
Codecov Report
@@ Coverage Diff @@
## 0.48 #2302 +/- ##
=======================================
Coverage ? 91.73%
=======================================
Files ? 575
Lines ? 41258
Branches ? 0
=======================================
Hits ? 37849
Misses ? 3409
Partials ? 0 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2295 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/