fix(grpc): no package in method service #2384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majorgreys
force-pushed
the
fix-grpc-method
branch
4 times, most recently
from
6c31b09 to
c7f3a34
Compare
majorgreys
force-pushed
the
fix-grpc-method
branch
from
c7f3a34 to
160f521
Compare
This was referenced Apr 30, 2021
P403n1x87
approved these changes
Apr 30, 2021
Kyle-Verhoog
approved these changes
Apr 30, 2021
Member
|
@Mergifyio backport 0.48 |
mergify bot
pushed a commit
that referenced
this pull request
May 12, 2021
* fix(grpc): add snapshot test for method service metadata * handle empty method package * revert change to host parsing * add release note * use async_mode Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 5c197a4) # Conflicts: # ddtrace/contrib/grpc/utils.py # tests/contrib/grpc/test_grpc.py
Contributor
|
Command
|
brettlangdon
pushed a commit
that referenced
this pull request
May 13, 2021
* fix(grpc): no package in method service (#2384) * fix(grpc): add snapshot test for method service metadata * handle empty method package * revert change to host parsing * add release note * use async_mode Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 5c197a4) # Conflicts: # ddtrace/contrib/grpc/utils.py # tests/contrib/grpc/test_grpc.py * Resolve conflict * fix snapshot Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> Co-authored-by: Kyle Verhoog <kyle.verhoog@datadoghq.com> Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2375
Failing test run with snapshot test: https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/7778/workflows/fce7f1aa-9965-491d-935e-1486e0f3e21c/jobs/657191
Checklist