Skip to content

Fix issue with tagging non-string Flask view args #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 10, 2021
Merged

Fix issue with tagging non-string Flask view args #2760

merged 4 commits into from
Aug 10, 2021

Conversation

@brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Aug 9, 2021

Fixes #2756

@brettlangdon brettlangdon requested a review from a team as a code owner August 9, 2021 20:43
@brettlangdon brettlangdon mentioned this pull request Aug 9, 2021
Closed
Yun-Kim
Yun-Kim previously approved these changes Aug 9, 2021
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021 •
edited by codecov bot
Loading

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.93%. Comparing base (19f4c5c) to head (0562d57).

Files with missing lines Patch % Lines
tests/contrib/flask/test_request.py 95.65% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2760   +/-   ##
=======================================
  Coverage   84.93%   84.93%           
=======================================
  Files         591      591           
  Lines       43113    43136   +23     
=======================================
+ Hits        36617    36639   +22     
- Misses       6496     6497    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

P403n1x87
P403n1x87 reviewed Aug 10, 2021
View reviewed changes
ddtrace/contrib/flask/patch.py
span._set_str_tag(u".".join((FLASK_VIEW_ARGS, k)), v)
# DEV: Do not use `_set_str_tag` here since view args can be string/int/float/path/uuid/etc
# https://flask.palletsprojects.com/en/1.1.x/api/#url-route-registrations
span.set_tag(u".".join((FLASK_VIEW_ARGS, k)), v)
Copy link
Contributor

@P403n1x87 P403n1x87 Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to cache the result of these string concats?

Copy link
Member Author

@brettlangdon brettlangdon Aug 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it might. we can handle that in a different PR

@majorgreys
Copy link
Contributor

majorgreys commented Aug 10, 2021

@Mergifyio backport 0.51

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2021

Command backport 0.51: pending

Waiting for the pull request to get merged

@mergify mergify bot merged commit 54a42fe into master Aug 10, 2021
@mergify mergify bot deleted the brettlangdon/fix.2756 branch August 10, 2021 14:38
mergify bot added a commit that referenced this pull request Aug 10, 2021
@brettlangdon @mergify
Fix issue with tagging non-string Flask view args (#2760)
b1b9da0 
* Fix issue with tagging non-string Flask view args
fixes #2756

* fix test method name

* fix json decoding when we have bytes

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 54a42fe)
@mergify mergify bot mentioned this pull request Aug 10, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2021

Command backport 0.51: success

Backports have been created

mergify bot added a commit that referenced this pull request Aug 10, 2021
@mergify @brettlangdon
Fix issue with tagging non-string Flask view args (#2760) (#2761)
e1dbc65 
* Fix issue with tagging non-string Flask view args
fixes #2756

* fix test method name

* fix json decoding when we have bytes

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 54a42fe)

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@P403n1x87 P403n1x87 P403n1x87 left review comments

@nizox nizox nizox approved these changes

@majorgreys majorgreys majorgreys approved these changes

@Yun-Kim Yun-Kim Yun-Kim left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flask view_args doesnt support non-string arguments

7 participants

@brettlangdon @codecov-commenter @majorgreys @nizox @P403n1x87 @Yun-Kim