Move contrib/aiohttp tests to riot #2866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Co-authored-by: Brett Langdon <me@brett.is>
Co-authored-by: Brett Langdon <me@brett.is>
mabdinur
added
the
changelog/no-changelog
Co-authored-by: Brett Langdon <me@brett.is>
Co-authored-by: Brett Langdon <me@brett.is>
Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Codecov Report
@@ Coverage Diff @@
## master #2866 +/- ##
==========================================
- Coverage 84.68% 84.67% -0.01%
==========================================
Files 607 607
Lines 44749 44752 +3
==========================================
- Hits 37894 37893 -1
- Misses 6855 6859 +4
Continue to review full report at Codecov.
|
riotfile.py
Outdated
| command="pytest {cmdargs} tests/contrib/aiohttp", | ||
| pkgs={"pytest-aiohttp": [latest]}, | ||
| venvs=[ | ||
| # Python 3.5 raises `NotImplemented: Can't perform operation for unregistered loader type` |
Contributor
|
I had opened a PR to do this in the past but I ran into some issues: #2637. It looks like the latest release of riot has fixed those? |
Member
|
@P403n1x87 it looks like the issues have been resolved! https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/11854/workflows/f2d0578[…]3-802e-4ad1d18044eb/jobs/878712/parallel-runs/1?filterBy=ALL |
P403n1x87
approved these changes
Oct 22, 2021
Member
|
@Mergifyio backport 0.55 |
Contributor
✅ Backports have been created
|
Kyle-Verhoog
added a commit
that referenced
this pull request
Nov 2, 2021
* Move aiohttp tests to riot Migrate aiohttp from tox to riot. Fixes #1370 * Pin async-timeout to <4.0.0 for older aiohttp versions (#2963) async-timeout introduces a breaking change (changing the `timeout` class to a function) which breaks older versions of aiohttp. Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
Move aiohttp tests to riot
Migrate aiohttp from tox to riot. Fixes #1370
Checklist