Skip to content

Conversation

@majorgreys
Copy link
Contributor

@majorgreys majorgreys commented Nov 11, 2021

Commit Message

{{title}}

Add the api endpoint to the log messages where we are reporting the agent url.

Checklist

  • Added to the correct milestone.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Library documentation is updated.
  • Corp site documentation is updated (link to the PR).

@majorgreys majorgreys requested a review from a team as a code owner November 11, 2021 17:47
@majorgreys majorgreys added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 11, 2021
Kyle-Verhoog
Kyle-Verhoog previously approved these changes Nov 11, 2021
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

Kyle-Verhoog
Kyle-Verhoog previously approved these changes Nov 11, 2021
brettlangdon
brettlangdon previously approved these changes Nov 11, 2021
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beat me to it!

@Kyle-Verhoog
Copy link
Member

Looks like there are additional test cases that need to be updated still

@brettlangdon
Copy link
Member

@Mergifyio backport 0.56

@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2021

backport 0.56

🟠 Waiting for conditions to match

  • merged [:pushpin: backport requirement]

brettlangdon
brettlangdon previously approved these changes Nov 12, 2021
brettlangdon
brettlangdon previously approved these changes Nov 12, 2021
@majorgreys majorgreys force-pushed the log-agent-endpoint branch 3 times, most recently from 0519ff2 to d426092 Compare November 12, 2021 19:03
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.37%. Comparing base (afd2b30) to head (0be5970).

Files with missing lines Patch % Lines
tests/integration/test_integration.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3003      +/-   ##
==========================================
- Coverage   84.37%   84.37%   -0.01%     
==========================================
  Files         623      623              
  Lines       45319    45323       +4     
==========================================
+ Hits        38238    38241       +3     
- Misses       7081     7082       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brettlangdon brettlangdon merged commit ce486c9 into DataDog:master Nov 12, 2021
mergify bot pushed a commit that referenced this pull request Nov 12, 2021
* Add agent endpoint to log messages

* more test fixes

(cherry picked from commit ce486c9)
@mergify
Copy link
Contributor

mergify bot commented Nov 12, 2021

backport 0.56

✅ Backports have been created

@majorgreys majorgreys deleted the log-agent-endpoint branch November 12, 2021 20:36
brettlangdon pushed a commit that referenced this pull request Nov 12, 2021
* Add agent endpoint to log messages

* more test fixes

(cherry picked from commit ce486c9)

Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants