tests(rq) support RQ 1.10.1 #3053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They changed the behavior for calling sync tasks, they will now no longer raise an exception.
brettlangdon
added
the
changelog/no-changelog
Member
Author
|
@Mergifyio backport 0.56 |
Contributor
🟠 Waiting for conditions to match
|
Kyle-Verhoog
approved these changes
Dec 7, 2021
| "span_id": 1, | ||
| "parent_id": 0, | ||
| "type": "worker", | ||
| "error": 1, |
Member
There was a problem hiding this comment.
should we consider this a breaking change?
Member
There was a problem hiding this comment.
discussed offline, it is but it's only for new versions of rq and the error information is still present on the child span.
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2021
They changed the behavior for calling sync tasks, they will now no longer raise an exception. (cherry picked from commit 8cd71af)
Contributor
✅ Backports have been created
|
brettlangdon
added a commit
that referenced
this pull request
Dec 7, 2021
* tests(rq) support RQ 1.10.1 (#3053) They changed the behavior for calling sync tasks, they will now no longer raise an exception. (cherry picked from commit 8cd71af) * Update tests/snapshots/tests.contrib.rq.test_rq.test_queue_failing_job_pre_1_10_1.json Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
{{title}}
They changed the behavior for calling sync tasks, they
will now no longer raise an exception.