fix(profiling/heap): check correctly maximum number of tracked allocs #3162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a possibility that the number of tracked allocs overflow the maximum if, e.g., 65k allocs are stored in the alloc tracker and then 1k allocs are stored in the freezer: when the freezer is merged back in the alloc tracker, then it will overflow.
brettlangdon
approved these changes
Jan 24, 2022
P403n1x87
approved these changes
Jan 24, 2022
Contributor
Author
|
@Mergifyio backport 0.57 |
mergify bot
pushed a commit
that referenced
this pull request
Jan 25, 2022
…#3162) There's a possibility that the number of tracked allocs overflow the maximum if, e.g., 65k allocs are stored in the alloc tracker and then 1k allocs are stored in the freezer: when the freezer is merged back in the alloc tracker, then it will overflow. Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com> (cherry picked from commit c861b8f)
Contributor
✅ Backports have been created
|
Kyle-Verhoog
pushed a commit
that referenced
this pull request
Jan 25, 2022
…#3162) (#3173) There's a possibility that the number of tracked allocs overflow the maximum if, e.g., 65k allocs are stored in the alloc tracker and then 1k allocs are stored in the freezer: when the freezer is merged back in the alloc tracker, then it will overflow. Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com> (cherry picked from commit c861b8f) Co-authored-by: Julien Danjou <julien.danjou@datadoghq.com>
mabdinur
pushed a commit
that referenced
this pull request
Jan 25, 2022
…#3162) There's a possibility that the number of tracked allocs overflow the maximum if, e.g., 65k allocs are stored in the alloc tracker and then 1k allocs are stored in the freezer: when the freezer is merged back in the alloc tracker, then it will overflow. Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com>
Contributor
Author
|
@Mergifyio backport 0.56 |
mergify bot
pushed a commit
that referenced
this pull request
Jan 26, 2022
…#3162) There's a possibility that the number of tracked allocs overflow the maximum if, e.g., 65k allocs are stored in the alloc tracker and then 1k allocs are stored in the freezer: when the freezer is merged back in the alloc tracker, then it will overflow. Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com> (cherry picked from commit c861b8f)
Contributor
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Jan 28, 2022
… (backport #3162) (#3181) This is an automatic backport of pull request #3162 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a possibility that the number of tracked allocs overflow the maximum
if, e.g., 65k allocs are stored in the alloc tracker and then 1k allocs are
stored in the freezer: when the freezer is merged back in the alloc tracker,
then it will overflow.