-
Notifications
You must be signed in to change notification settings - Fork 468
chore(docs): add custom directive to dynamically generate release notes #3368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d869396 to
810c6bb
Compare
Kyle-Verhoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits, otherwise lgtm
f094053 to
1e14eb0
Compare
|
This PR still doesn't solve is, adding the unreleased notes from the current branch so we can validate spell checking on them, or so we can see what is unreleased on As well, one side effect of this PR, any branch that has this directive will always build from all release branches. Meaning when we release a bugfix release it will include release notes for all new major/minor versions that have been released. For example: We release 0.70.0, 0.71.0, and then 0.70.1 When we build the docs for 0.70.1 this change will also include 0.71.0's release notes instead of only being for <= 0.70.x. We can probably get around this by checking if the current commit is for a release tag and then limiting to only that minor version as a max. And checking for this could also help us with the spell checking on PR as well, if we notice the current commit is not for a specific release tag (and we are not on a release branch), then we can build the current branches release notes as well.... we just have to maybe get creative in how we know which release notes are unreleased/not in a release branch (reno has trouble with this as-is). |
|
@Mergifyio backport 0.x |
1e14eb0 to
049194c
Compare
🟠 Waiting for conditions to match
|
b8a84f4 to
3238928
Compare
Codecov Report
@@ Coverage Diff @@
## 1.x #3368 +/- ##
=======================================
Coverage 79.46% 79.46%
=======================================
Files 615 615
Lines 46427 46427
=======================================
Hits 36895 36895
Misses 9532 9532 Continue to review full report at Codecov.
|
3238928 to
11cea56
Compare
adac32e to
7ceb1ae
Compare
|
I have updated this PR to address the issue of always generating ALL the notes. Now we will look for the max version we should report for by traversing the git log until we find the first ref for a release branch or dev branch. We will then use that to determine the max version to generate for. For example, for this branch it will find This will ensure that when we generate notes for older versions we don't include newer version in the log. |
8dad192 to
bd57825
Compare
This new `.. ddtrace-release-notes::` directive will dynamically search for all release branches + earliest release version and generate the desired release notes
bd57825 to
d3b18e8
Compare
Kyle-Verhoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nits, otherwise lgtm
|
@Mergifyio backport 1.0 0.60 0.59 |
🟠 Waiting for conditions to match
|
|
Example generated from this PR: https://output.circle-artifacts.com/output/job/b31402fc-bc7c-4d37-864a-8718b5904dc2/artifacts/0/tmp/docs/release_notes.html |
…es (#3368) * chore(docs): add custom directive to dynamically generate release notes This new `.. ddtrace-release-notes::` directive will dynamically search for all release branches + earliest release version and generate the desired release notes * Update docs/conf.py (cherry picked from commit a357d8d) # Conflicts: # docs/release_notes.rst
…es (#3368) * chore(docs): add custom directive to dynamically generate release notes This new `.. ddtrace-release-notes::` directive will dynamically search for all release branches + earliest release version and generate the desired release notes * Update docs/conf.py (cherry picked from commit a357d8d) # Conflicts: # docs/release_notes.rst
✅ Backports have been created
|
✅ Backports have been created
|
…es (#3368) * chore(docs): add custom directive to dynamically generate release notes This new `.. ddtrace-release-notes::` directive will dynamically search for all release branches + earliest release version and generate the desired release notes * Update docs/conf.py (cherry picked from commit a357d8d)
|
Example from the |
…es (#3368) * chore(docs): add custom directive to dynamically generate release notes This new `.. ddtrace-release-notes::` directive will dynamically search for all release branches + earliest release version and generate the desired release notes * Update docs/conf.py (cherry picked from commit a357d8d)
…es (#3368) (#3474) * chore(docs): add custom directive to dynamically generate release notes This new `.. ddtrace-release-notes::` directive will dynamically search for all release branches + earliest release version and generate the desired release notes * Update docs/conf.py (cherry picked from commit a357d8d) Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
…es (#3368) (#3477) * chore(docs): add custom directive to dynamically generate release notes This new `.. ddtrace-release-notes::` directive will dynamically search for all release branches + earliest release version and generate the desired release notes * Update docs/conf.py (cherry picked from commit a357d8d) Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
…es (#3368) (#3477) * chore(docs): add custom directive to dynamically generate release notes This new `.. ddtrace-release-notes::` directive will dynamically search for all release branches + earliest release version and generate the desired release notes * Update docs/conf.py (cherry picked from commit a357d8d) Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> (cherry picked from commit d4e5260)
…es (#3368) (#3477) (#3479) * chore(docs): add custom directive to dynamically generate release notes This new `.. ddtrace-release-notes::` directive will dynamically search for all release branches + earliest release version and generate the desired release notes * Update docs/conf.py (cherry picked from commit a357d8d) Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> (cherry picked from commit d4e5260) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This new
.. ddtrace-release-notes::directive will dynamically search for allrelease branches + earliest release version and generate the desired release notes