fix(grpc_aio): new version 1.48.0 has updated error message #4013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avara1986
added
the
changelog/no-changelog
juanjux
approved these changes
Jul 29, 2022
gnufede
approved these changes
Jul 29, 2022
Codecov Report
@@ Coverage Diff @@
## 1.x #4013 +/- ##
==========================================
+ Coverage 79.48% 79.50% +0.01%
==========================================
Files 714 714
Lines 55787 55836 +49
==========================================
+ Hits 44344 44393 +49
Misses 11443 11443
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Contributor
|
@Mergifyio backport 1.3 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2022
## Description New version 1.48.0 of grpc has updated error message: https://github.com/grpc/grpc/releases/tag/v1.48.0 ``` > assert client_span.get_tag(ERROR_MSG) == "failed to connect to all addresses" E AssertionError: assert 'failed to co...ction refused' == 'failed to co...all addresses' E - failed to connect to all addresses E + failed to connect to all addresses; last error: UNKNOWN: Failed to connect to remote host: Connection refused ``` ## Checklist - [x] Title must conform to [conventional commit](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional). - [x] Add additional sections for `feat` and `fix` pull requests. - [x] Ensure tests are passing for affected code. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. ## Reviewer Checklist - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] PR cannot be broken up into smaller PRs. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added for fixes and features, or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio. - [ ] Add to milestone. (cherry picked from commit c447239)
Kyle-Verhoog
pushed a commit
that referenced
this pull request
Sep 20, 2022
…4212) ## Description New version 1.48.0 of grpc has updated error message: https://github.com/grpc/grpc/releases/tag/v1.48.0 ``` > assert client_span.get_tag(ERROR_MSG) == "failed to connect to all addresses" E AssertionError: assert 'failed to co...ction refused' == 'failed to co...all addresses' E - failed to connect to all addresses E + failed to connect to all addresses; last error: UNKNOWN: Failed to connect to remote host: Connection refused ``` ## Checklist - [x] Title must conform to [conventional commit](https://github.com/conventional-changelog/commitlint/tree/master/%40commitlint/config-conventional). - [x] Add additional sections for `feat` and `fix` pull requests. - [x] Ensure tests are passing for affected code. - [ ] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. ## Reviewer Checklist - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] PR cannot be broken up into smaller PRs. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added for fixes and features, or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio. - [ ] Add to milestone. (cherry picked from commit c447239) Co-authored-by: Alberto Vara <alberto.vara@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New version 1.48.0 of grpc has updated error message: https://github.com/grpc/grpc/releases/tag/v1.48.0
Checklist
featandfixpull requests.Reviewer Checklist
changelog/no-changeloglabel added.