-
Notifications
You must be signed in to change notification settings - Fork 469
chore(ci): enabling partial flushing by default #4041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
417f0d7 to
53394d8
Compare
fbb52bd to
6f99023
Compare
|
Not sure why the integration tests are failing as in some cases, they do enable the partial flush but even setting Likewise, asyncio and ddtracerun do not use partial flush in their code so not sure if it's expected that they should be failing. |
f914c1b to
b13450d
Compare
b13450d to
3dfa76e
Compare
mawais54013
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like in some cases depending on the python version, the calls length might be longer than expected. Is the log.warning necessary in this case or is there a better and dynamic way of handling this behavior
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
ZStriker19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, should we make docs changes or do we just never document this?
mabdinur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳
ZStriker19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit but feel free to ignore if you like your wording more.
Co-authored-by: Zachary Groves <32471391+ZStriker19@users.noreply.github.com>
Yun-Kim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the one test case to add 😄
mabdinur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳
Codecov Report
@@ Coverage Diff @@
## 1.x #4041 +/- ##
==========================================
- Coverage 78.27% 78.23% -0.05%
==========================================
Files 726 726
Lines 58268 58305 +37
==========================================
+ Hits 45612 45614 +2
- Misses 12656 12691 +35
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks like the |
|
Blocking for now until we have a handle on end-to-end testing of this feature. |
Description
Enabling payload partial flush by default
Resolves #1632
Checklist
featandfixpull requests.Reviewer Checklist
changelog/no-changeloglabel added.