Skip to content

Conversation

@mabdinur
Copy link
Contributor

Description

Adds DD_TRACE_SQL_COMMENT_INJECTION_MODE environment variable

Checklist

Motivation

Design

Testing strategy

Relevant issue(s)

Testing strategy

Reviewer Checklist

  • Title is accurate.
  • Description motivates each change.
  • No unnecessary changes were introduced in this PR.
  • PR cannot be broken up into smaller PRs.
  • Avoid breaking API changes unless absolutely necessary.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Release note has been added for fixes and features, or else changelog/no-changelog label added.
  • All relevant GitHub issues are correctly linked.
  • Backports are identified and tagged with Mergifyio.
  • Add to milestone.

@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Oct 12, 2022
@mabdinur mabdinur force-pushed the ait-4384/dbmlink-configure-injection-mode branch 2 times, most recently from a572941 to a44816e Compare October 12, 2022 20:33
@mabdinur mabdinur marked this pull request as ready for review October 13, 2022 01:55
@mabdinur mabdinur requested a review from a team as a code owner October 13, 2022 01:55
@mabdinur mabdinur force-pushed the ait-4384/dbmlink-configure-injection-mode branch from a44816e to e7bca03 Compare October 13, 2022 14:03
@mabdinur mabdinur requested a review from majorgreys October 13, 2022 14:13
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #4306 (50ee9a8) into 1.x (dd1b0cf) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head 50ee9a8 differs from pull request most recent head 6d98328. Consider uploading reports for the commit 6d98328 to get more accurate results

@@            Coverage Diff             @@
##              1.x    #4306      +/-   ##
==========================================
- Coverage   78.24%   78.15%   -0.10%     
==========================================
  Files         745      749       +4     
  Lines       59359    59429      +70     
==========================================
+ Hits        46446    46447       +1     
- Misses      12913    12982      +69     
Impacted Files Coverage Δ
ddtrace/profiling/profiler.py 0.00% <0.00%> (ø)
ddtrace/settings/database_monitoring.py 0.00% <0.00%> (ø)
tests/internal/test_database_monitoring.py 0.00% <0.00%> (ø)
tests/profiling/gunicorn-app.py 0.00% <0.00%> (ø)
tests/profiling/test_gunicorn.py 0.00% <0.00%> (ø)
ddtrace/internal/telemetry/writer.py 76.71% <0.00%> (+0.68%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit b2e9be7 into 1.x Oct 14, 2022
@mergify mergify bot deleted the ait-4384/dbmlink-configure-injection-mode branch October 14, 2022 18:15
@github-actions github-actions bot added this to the v1.6.0 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants