Skip to content

Conversation

@gnufede
Copy link
Member

@gnufede gnufede commented May 16, 2023

CI App: Remove extra requests performed if DD_CIVISIBILITY_ITR_ENABLED env var not set or False.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • OPTIONAL: PR description includes explicit acknowledgement of the performance implications of the change as reported in the benchmarks PR comment.

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.

@gnufede gnufede added the CI App label May 16, 2023
@gnufede gnufede marked this pull request as ready for review May 16, 2023 16:23
@gnufede gnufede requested review from a team as code owners May 16, 2023 16:23
@Yun-Kim Yun-Kim changed the title fix(ci-app): remove extra requests performed if env var not set fix(ci-visibility): remove extra requests performed if env var not set May 16, 2023
Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
@gnufede gnufede enabled auto-merge (squash) May 16, 2023 16:50
@gnufede gnufede requested a review from Yun-Kim May 16, 2023 16:53
@pr-commenter
Copy link

pr-commenter bot commented May 16, 2023

Benchmarks

Comparing candidate commit c8b3438 in PR branch gnufede/fix-api-call-under-env-var with baseline commit 1937b15 in branch 1.x.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 93 cases.

scenario:flasksimple-tracer-and-profiler

  • 🟥 execution_time [+0.445ms; +0.565ms] or [+7.245%; +9.204%]

@gnufede gnufede merged commit 9ff8aae into 1.x May 17, 2023
@gnufede gnufede deleted the gnufede/fix-api-call-under-env-var branch May 17, 2023 10:36
@github-actions github-actions bot added this to the v1.14.0 milestone May 17, 2023
gnufede added a commit that referenced this pull request May 17, 2023
#5872)

CI App: Remove extra requests performed if
``DD_CIVISIBILITY_ITR_ENABLED`` env var not set or False.

## Checklist
- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines)
are followed.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] OPTIONAL: PR description includes explicit acknowledgement of the
performance implications of the change as reported in the benchmarks PR
comment.

## Reviewer Checklist
- [ ] Title is accurate.
- [ ] No unnecessary changes are introduced.
- [ ] Description motivates each change.
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [ ] Testing strategy adequately addresses listed risk(s).
- [ ] Change is maintainable (easy to change, telemetry, documentation).
- [ ] Release note makes sense to a user of the library.
- [ ] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.

---------

Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
(cherry picked from commit 9ff8aae)
gnufede added a commit that referenced this pull request May 17, 2023
…t [backport #5872 to 1.13] (#5881)

Backport of #5872 to 1.13

CI App: Remove extra requests performed if
``DD_CIVISIBILITY_ITR_ENABLED`` env var not set or False.

## Checklist
- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines)
are followed.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] OPTIONAL: PR description includes explicit acknowledgement of the
performance implications of the change as reported in the benchmarks PR
comment.

## Reviewer Checklist
- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants