Skip to content

Conversation

@gnufede
Copy link
Member

@gnufede gnufede commented May 17, 2023

Backport of #5872 to 1.13

CI App: Remove extra requests performed if DD_CIVISIBILITY_ITR_ENABLED env var not set or False.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • OPTIONAL: PR description includes explicit acknowledgement of the performance implications of the change as reported in the benchmarks PR comment.

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.

#5872)

CI App: Remove extra requests performed if
``DD_CIVISIBILITY_ITR_ENABLED`` env var not set or False.

## Checklist
- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines)
are followed.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] OPTIONAL: PR description includes explicit acknowledgement of the
performance implications of the change as reported in the benchmarks PR
comment.

## Reviewer Checklist
- [ ] Title is accurate.
- [ ] No unnecessary changes are introduced.
- [ ] Description motivates each change.
- [ ] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [ ] Testing strategy adequately addresses listed risk(s).
- [ ] Change is maintainable (easy to change, telemetry, documentation).
- [ ] Release note makes sense to a user of the library.
- [ ] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.

---------

Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
(cherry picked from commit 9ff8aae)
@gnufede gnufede requested review from a team as code owners May 17, 2023 14:19
@gnufede gnufede added the CI App label May 17, 2023
@gnufede gnufede enabled auto-merge (squash) May 17, 2023 14:20
@pr-commenter
Copy link

pr-commenter bot commented May 17, 2023

Benchmarks

Comparing candidate commit 8953e69 in PR branch backport-5872-to-1.13 with baseline commit df4f405 in branch 1.13.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 94 cases.

mabdinur
mabdinur previously approved these changes May 17, 2023
@gnufede gnufede merged commit e93a6e0 into 1.13 May 17, 2023
@gnufede gnufede deleted the backport-5872-to-1.13 branch May 17, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants