Skip to content

chore(testing): add 3.12-dev testing#7035

Merged
emmettbutler merged 6 commits into2.xfrom
zachg/add_system-tests_for_2.x_and_312
Sep 25, 2023
Merged

chore(testing): add 3.12-dev testing#7035
emmettbutler merged 6 commits into2.xfrom
zachg/add_system-tests_for_2.x_and_312

Conversation

@ZStriker19
Copy link
Copy Markdown
Collaborator

@ZStriker19 ZStriker19 commented Sep 25, 2023

A new weblog variant was added for system-tests here: DataDog/system-tests#1617
This runs that new variant so we test 2.x on 3.12

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy
  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

emmettbutler
emmettbutler previously approved these changes Sep 25, 2023
@emmettbutler emmettbutler mentioned this pull request Sep 25, 2023
1 task
@emmettbutler emmettbutler added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 25, 2023
@ZStriker19 ZStriker19 changed the title chore (system-tests): add 3.12-dev testing chore (system_tests): add 3.12-dev testing Sep 25, 2023
emmettbutler
emmettbutler previously approved these changes Sep 25, 2023
@emmettbutler emmettbutler changed the title chore (system_tests): add 3.12-dev testing chore (testing): add 3.12-dev testing Sep 25, 2023
@emmettbutler emmettbutler changed the title chore (testing): add 3.12-dev testing chore(testing): add 3.12-dev testing Sep 25, 2023
@emmettbutler emmettbutler enabled auto-merge (squash) September 25, 2023 17:38
@ZStriker19 ZStriker19 marked this pull request as draft September 25, 2023 18:02
auto-merge was automatically disabled September 25, 2023 18:02

Pull request was converted to draft

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Sep 25, 2023

Benchmarks

Benchmark execution time: 2023-09-25 19:50:57

Comparing candidate commit 6a67196 in PR branch zachg/add_system-tests_for_2.x_and_312 with baseline commit 4997cab in branch 2.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 90 metrics, 0 unstable metrics.

@ZStriker19 ZStriker19 marked this pull request as ready for review September 25, 2023 20:01
@ZStriker19
Copy link
Copy Markdown
Collaborator Author

I think parametric is just failing because we're not skipping the deprecated b3 tests, which this should fix: DataDog/system-tests#1621

@emmettbutler emmettbutler self-requested a review September 25, 2023 20:56
@emmettbutler emmettbutler merged commit 0982220 into 2.x Sep 25, 2023
@emmettbutler emmettbutler deleted the zachg/add_system-tests_for_2.x_and_312 branch September 25, 2023 20:56
@github-actions github-actions Bot added this to the v2.1.0 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants