Skip to content

[aiohttp] Fix race condition in testing #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2019
Merged

[aiohttp] Fix race condition in testing #877

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5ba9d1
[aiohttp] Fix race condition in testing
jd Apr 5, 2019
8fb4ebd
Merge branch '0.24-dev' into fix-aiohttp-test-race
jd Apr 9, 2019
3ea963c
Merge branch '0.24-dev' into fix-aiohttp-test-race
jd Apr 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tests/contrib/aiohttp/test_request_safety.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,13 @@ def make_requests():
ctx = self.tracer.get_call_context()
threads = [threading.Thread(target=make_requests) for _ in range(10)]
for t in threads:
t.daemon = True
t.start()

# we should yield so that this loop can handle
# threads' requests
yield from asyncio.sleep(0.5)
for t in threads:
t.join(timeout=0.5)
# we should yield so that this loop can handle
# threads' requests
yield from asyncio.sleep(0.1)
t.join(0.1)

# the trace is wrong but the Context is finished
traces = self.tracer.writer.pop_traces()
Expand Down