Skip to content

Add at_exit hook for Tracer shutdown#884

Merged
delner merged 2 commits intomasterfrom
feature/flush_at_exit-master
Dec 16, 2019
Merged

Add at_exit hook for Tracer shutdown#884
delner merged 2 commits intomasterfrom
feature/flush_at_exit-master

Conversation

@marcotc
Copy link
Copy Markdown
Member

@marcotc marcotc commented Dec 12, 2019

#820 was merged into the old release branch.
This PR applies that same changeset to master instead.

Original description:

When traced Ruby processes are terminated, they may not permit the worker an opportunity to flush existing traces. This pull request adds an at_exit hook that calls shutdown! on the Tracer, so it can be cleaned up in a more graceful fashion.

@marcotc marcotc added core Involves Datadog core libraries feature Involves a product feature labels Dec 12, 2019
@marcotc marcotc requested a review from a team December 12, 2019 00:40
Copy link
Copy Markdown
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner delner merged commit 84e7178 into master Dec 16, 2019
@delner delner deleted the feature/flush_at_exit-master branch December 16, 2019 21:36
@delner delner added this to the 0.31.0 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Involves Datadog core libraries feature Involves a product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants