fix: improve statsd write error handling#540
Merged
KowalskiThomas merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
nsavoire
reviewed
Apr 13, 2026
Collaborator
|
Thanks for looking into this, how did you find this issue ? |
Contributor
Author
Messing around with coding agents on plane wifi 😛 |
Collaborator
Perhaps we will want to generalize this messing around process ^^, we can talk about this. |
KowalskiThomas
changed the title
statsd write error handling
nsavoire
previously approved these changes
Apr 14, 2026
KowalskiThomas
force-pushed
the
kowalski/fix-un-deadify-error-handling
branch
from
2da80aa to
8f5ecd2
Compare
KowalskiThomas
force-pushed
the
kowalski/fix-un-deadify-error-handling
branch
from
8f5ecd2 to
bd5e1f2
Compare
Contributor
Author
|
@nsavoire re-requested review since fixing CI and pushing the branch dismissed it 😭 |
nsavoire
approved these changes
Apr 14, 2026
Collaborator
nsavoire
left a comment
nsavoire
left a comment
There was a problem hiding this comment.
Thanks for the fixes !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes an error handling code path non dead. Previously, we would check the
errnobefore getting into the block, making the second check onerrnouseless/redundant/dead.