Skip to content

[SDTEST] Update troubleshooting section of Intelligent Test Runner #23817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rtrieu merged 3 commits into from
Jun 24, 2024
Merged

[SDTEST] Update troubleshooting section of Intelligent Test Runner #23817

rtrieu merged 3 commits into from
Jun 24, 2024

Conversation

@TovRudyy
Copy link
Contributor

@TovRudyy TovRudyy commented Jun 24, 2024 •
edited
Loading

What does this PR do? What is the motivation?

Updates the troubleshooting section of Intelligent Test Runner.

Merge instructions

  • Please merge after reviewing

Additional notes

@TovRudyy TovRudyy requested review from a team as code owners June 24, 2024 09:57
@TovRudyy TovRudyy force-pushed the olek.rudyy/itr-limitation branch from 555a377 to ba8621c Compare June 24, 2024 09:59
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024

Preview links (active after the build_preview check completes)

Modified Files

@TovRudyy TovRudyy force-pushed the olek.rudyy/itr-limitation branch from ba8621c to 1de247e Compare June 24, 2024 10:00
@TovRudyy TovRudyy force-pushed the olek.rudyy/itr-limitation branch 2 times, most recently from 0eed0ea to 89c3ed0 Compare June 24, 2024 13:15
@TovRudyy TovRudyy changed the title [SDTEST] ITR with GH Actions limitation (troubleshooting) [SDTEST] Update troubleshooting section of Intelligent Test Runner Jun 24, 2024
@TovRudyy TovRudyy force-pushed the olek.rudyy/itr-limitation branch from 89c3ed0 to b65631f Compare June 24, 2024 13:36
@TovRudyy TovRudyy added the aaa-access AAA Access team: https://datadoghq.atlassian.net/wiki/spaces/AAA/pages/2069365080/AAA+Access+Team label Jun 24, 2024
anmarchenko
anmarchenko reviewed Jun 24, 2024
View reviewed changes
content/en/intelligent_test_runner/troubleshooting/_index.md Outdated

### Squash and merge your commits

Using [squash and merge][6] to integrate commits into de main branch causes the git history of the feature branch to be lost. As a result Intelligent Test Runner can run tests in the main branch that should have been skipped.
Copy link
Member

@anmarchenko anmarchenko Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run tests in the main branch that should have been skipped - I think we recommend set main branch as excluded so that tests are not skipped. Mentioning that tests in main might not be skipped could cause confusion.

Copy link
Contributor Author

@TovRudyy TovRudyy Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced main with base, so it's generic and doesn't apply to main necessarily.

rtrieu
rtrieu reviewed Jun 24, 2024
View reviewed changes
rtrieu
rtrieu requested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback but otherwise looks good.

@TovRudyy TovRudyy removed the aaa-access AAA Access team: https://datadoghq.atlassian.net/wiki/spaces/AAA/pages/2069365080/AAA+Access+Team label Jun 24, 2024
@TovRudyy TovRudyy requested review from anmarchenko and rtrieu June 24, 2024 14:23
rtrieu
rtrieu approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TovRudyy
Copy link
Contributor Author

TovRudyy commented Jun 24, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 24, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@TovRudyy
Copy link
Contributor Author

TovRudyy commented Jun 24, 2024

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Jun 24, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

rtrieu
rtrieu approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rtrieu rtrieu merged commit 5bc7341 into master Jun 24, 2024
@rtrieu rtrieu deleted the olek.rudyy/itr-limitation branch June 24, 2024 15:35
@rtrieu
Copy link
Contributor

rtrieu commented Jun 24, 2024

Hi @TovRudyy, the docs team has privileges to merge this branch. Next time, you can use the checkbox "Please merge after reviewing", reply to the reviewer here, or ping the #documentation Slack channel to let us know when you're ready to merge!

@TovRudyy TovRudyy restored the olek.rudyy/itr-limitation branch June 24, 2024 15:46
@TovRudyy TovRudyy mentioned this pull request Jun 24, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rtrieu rtrieu rtrieu approved these changes

@romainkomorn-exdatadog romainkomorn-exdatadog Awaiting requested review from romainkomorn-exdatadog romainkomorn-exdatadog was automatically assigned from DataDog/ci-app-libraries

@anmarchenko anmarchenko Awaiting requested review from anmarchenko

Assignees

No one assigned

Labels

mergequeue-status: removed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TovRudyy @rtrieu @anmarchenko