Update rds.md #25443
Open
Update rds.md #25443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding interest form for RDS agent setup script (take 2)
lu-zhengda
approved these changes
Sep 26, 2024
drichards-87
requested changes
Sep 26, 2024
Contributor
drichards-87
left a comment
drichards-87
left a comment
There was a problem hiding this comment.
Left a couple of small suggestions. Also, let me know if this PR is ready to be merged.
Contributor
|
Hi @J0ns0x. I just wanted to follow-up on this PR to see if it's still relevant/needs to be merged. |
Contributor
Author
|
yes! I'm behind on implementing your suggestion in slack. hopefully
tomorrow.. thanks for the tip...
…On Mon, Sep 30, 2024 at 1:04 PM DeForest Richards ***@***.***> wrote:
Hi @J0ns0x <https://github.com/J0ns0x>. I just wanted to follow-up on
this PR to see if it's still relevant/needs to be merged.
—
Reply to this email directly, view it on GitHub
<#25443 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK3XWGJFCGCGEJGBY2Z4P3TZZGACLAVCNFSM6AAAAABO5BML3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTG4ZDSNRRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding interest form for RDS agent setup script (take 2)
What does this PR do? What is the motivation?
Merge instructions
Additional notes