Skip to content

[error-tracking] Merge Default Grouping and Custom grouping pages #25874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 13 commits into from
Mar 28, 2025
Merged

[error-tracking] Merge Default Grouping and Custom grouping pages #25874

dd-mergequeue merged 13 commits into from
Mar 28, 2025

Conversation

@cgcote
Copy link
Contributor

@cgcote cgcote commented Oct 23, 2024 •
edited
Loading

What does this PR do? What is the motivation?

This PR merges the two error tracking grouping pages into one. We would like to make the custom fingerprinting less visible and have all the information in one place.

Merge instructions

  • Please merge after reviewing

Additional notes

the old page custom_grouping should redirect to error_grouping?tab=ios#custom-grouping
the old page default_grouping should redirect to error_grouping?tab=ios#default-grouping

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Oct 23, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Preview links (active after the build_preview check completes)

New or renamed files

Removed or renamed files (these should redirect)

Renamed files

@cgcote cgcote force-pushed the charles.cote/merge-error-tracking-grouping-pages branch 2 times, most recently from 6c75fa7 to 13bd457 Compare October 23, 2024 12:28
@cgcote cgcote marked this pull request as ready for review October 23, 2024 12:28
@cgcote cgcote requested a review from a team as a code owner October 23, 2024 12:28
@rtrieu
Copy link
Contributor

rtrieu commented Oct 23, 2024

Created DOCS-9327 for editorial review.

@cgcote cgcote force-pushed the charles.cote/merge-error-tracking-grouping-pages branch from 13bd457 to 03a2c33 Compare October 23, 2024 13:55
@rtrieu rtrieu added the editorial review Waiting on a more in-depth review label Oct 23, 2024
@rtrieu
Copy link
Contributor

rtrieu commented Oct 23, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 23, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@rtrieu
Copy link
Contributor

rtrieu commented Oct 23, 2024

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Oct 23, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

rtrieu
rtrieu requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cgcote, thanks for this PR! I've left some feedback for your review. I also added the required redirects, but unfortunately there's not a way for us to send users to a specific section - they will simply be redirected to the page.

cgcote and others added 2 commits November 12, 2024 12:54
@cgcote @rtrieu
Apply suggestions from code review
658343c 
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
@rtrieu
Merge branch 'master' into charles.cote/merge-error-tracking-grouping…
db29c4a 
…-pages
@rtrieu
Copy link
Contributor

rtrieu commented Jan 8, 2025

Hi @cgcote, can you go ahead and resolve the conflict?

@rtrieu
Copy link
Contributor

rtrieu commented Mar 28, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 28, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-03-28 14:32:30 UTC ℹ️ Start processing command /merge

2025-03-28 14:32:38 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 17m (p90).

2025-03-28 14:47:35 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 6d861a0 into master Mar 28, 2025
15 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the charles.cote/merge-error-tracking-grouping-pages branch March 28, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rtrieu rtrieu rtrieu approved these changes

Assignees

No one assigned

Labels

Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cgcote @rtrieu @bgdeutsch