Skip to content

[DOCS-9372] Move tracking stuff from setup to advanced config #26882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 8 commits into from
Jan 10, 2025
Merged

[DOCS-9372] Move tracking stuff from setup to advanced config #26882

dd-mergequeue merged 8 commits into from
Jan 10, 2025

Conversation

@rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Dec 20, 2024 •
edited
Loading

What does this PR do? What is the motivation?

  • Moves some tracking config info from the Setup page to Advanced Configuration for iOS, Flutter, React Native, Expo, and Roku
  • Fixes the ordering of links

Note: This PR does not contain new content; it moves around existing content from one page to another.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@rtrieu rtrieu requested review from a team as code owners December 20, 2024 21:34
@rtrieu rtrieu changed the title Move tracking stuff from setup to advanced config [DOCS-9372] Move tracking stuff from setup to advanced config Dec 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024

Preview links (active after the build_preview check completes)

Modified Files

@hestonhoffman hestonhoffman added the editorial review Waiting on a more in-depth review label Dec 20, 2024
git-thuerk-done
git-thuerk-done requested changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@git-thuerk-done git-thuerk-done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rtrieu looks good just a few broken links that need fixed, let me know when you're ready for a re-review !

git-thuerk-done
git-thuerk-done previously requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@git-thuerk-done git-thuerk-done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rtrieu thanks for updating these, just a couple more that need tweaked :)

@rtrieu
Copy link
Contributor Author

rtrieu commented Jan 2, 2025

@aliciascott thanks for catching the broken links!

@rtrieu rtrieu requested a review from git-thuerk-done January 2, 2025 15:32
@rtrieu
Copy link
Contributor Author

rtrieu commented Jan 6, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 6, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-06 19:38:53 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-01-06 23:38:55 UTC ⚠️ MergeQueue: This merge request was unqueued

rosa.trieu@datadoghq.com unqueued this merge request: It did not become mergeable within the expected time

@rtrieu
Copy link
Contributor Author

rtrieu commented Jan 7, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 7, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-07 14:43:33 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-01-07 18:43:40 UTC ⚠️ MergeQueue: This merge request was unqueued

rosa.trieu@datadoghq.com unqueued this merge request: It did not become mergeable within the expected time

@rtrieu rtrieu dismissed git-thuerk-done’s stale review January 10, 2025 17:34

all feedback about broken urls have been addressed and another docs team member has approved

@rtrieu
Copy link
Contributor Author

rtrieu commented Jan 10, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 10, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-10 17:34:18 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.

2025-01-10 17:42:10 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 7e259a2 into master Jan 10, 2025
24 of 33 checks passed
@dd-mergequeue dd-mergequeue bot deleted the rtrieu/docs-9372-move-setup-to-advanced-config-rum branch January 10, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cswatt cswatt cswatt approved these changes

@git-thuerk-done git-thuerk-done Awaiting requested review from git-thuerk-done

+1 more reviewer

@xgouchet xgouchet xgouchet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

editorial review Waiting on a more in-depth review mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rtrieu @xgouchet @cswatt @git-thuerk-done @hestonhoffman