Notifcation Grouping header #27370
Merged
Notifcation Grouping header #27370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/merge |
Devflow running:
|
Contributor
Preview links (active after the
|
janine-c
reviewed
Jan 29, 2025
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
Contributor
Author
|
Yes, that makes sense. Thanks!
…On Wed, Jan 29, 2025 at 1:57 PM Janine Chan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In content/en/monitors/configuration/_index.md
<#27370 (comment)>
:
> @@ -270,6 +270,8 @@ A `Multi Alert` monitor triggers individual notifications for each entity in a m
For example, when setting up a monitor to notify you if the P99 latency, aggregated by service, exceeds a certain threshold, you would receive a **separate** alert for each individual service whose P99 latency exceeded the alert threshold. This can be useful for identifying and addressing specific instances of system or application issues. It allows you to track problems on a more granular level.
+#### Notification grouping
Thanks for this, @DavidGrashton <https://github.com/DavidGrashton>!
Because this content also pertains to multi alert, would you be cool with
nesting the heading down one more level?
⬇️ Suggested change
-#### Notification grouping
+##### Notification grouping
—
Reply to this email directly, view it on GitHub
<#27370 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQ5MYLZVC6IB4U7MTX3G7D2NFFGBAVCNFSM6AAAAABWD3LMXWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOBSGQ2TMNZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
dd-devflow
bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
janine-c
approved these changes
Jan 30, 2025
Contributor
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
DavidGrashton/notification-grouping-header
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Adds the heading "Notification grouping" to the section discussing that feature. Previously this term was only contained in an image, which Alerting Product stated was making it hard to google this info. It also makes the overall "Set alert aggregation" section more clear and uniform.
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes