Topherc dd/aas code sidecar updates #29614
Conversation
github-actions
bot
added
Images
📝 Documentation Team Review RequiredThis pull request requires approval from the @DataDog/documentation team before it can be merged. Please ensure your changes follow our documentation guidelines and wait for a team member to review and approve your changes. |
Preview links (active after the
|
|
Created DOCS-11080 for Docs Team review. |
content/en/serverless/azure_app_services/azure_app_services_linux.md
Outdated
Show resolved
Hide resolved
|
|
||
| | Name | Value | | ||
| | ---- | ----- | | ||
| | `DD_CUSTOM_METRICS_ENABLED` | `true` | |
There was a problem hiding this comment.
This may have been only required when using wrapper scripts. @jcstorms1 can you confirm?
There was a problem hiding this comment.
ah fair, i will ask
There was a problem hiding this comment.
This may have been only required when using wrapper scripts. @jcstorms1 can you confirm?
Yes DD_CUSTOM_METRICS_ENABLED is an environment that is only looked at in the wrapper script, not in datadog-agent.
https://github.com/DataDog/datadog-aas-linux/blob/540962b7e669aed6bfd244f29860824cb985cac8/datadog_wrapper#L84-L86
| [10]: https://docs.datadoghq.com/developers/dogstatsd/?tab=hostagent&code-lang=php | ||
| [11]: https://docs.datadoghq.com/developers/dogstatsd/?tab=hostagent&code-lang=python |
There was a problem hiding this comment.
For all runtimes, can we link to the client instructions for Dogstatsd directly, e.g. https://docs.datadoghq.com/developers/dogstatsd/?tab=java&code-lang=java#install-the-dogstatsd-client. The rest of the page is not super relevant and somewhat confusing for a first time customer.
duncanpharvey
left a comment
duncanpharvey
left a comment
There was a problem hiding this comment.
Should a link to the wrapper script guide be added here?
https://docs.datadoghq.com/serverless/guide/
content/en/serverless/guide/azure_app_service_linux_code_wrapper_script.md
Show resolved
Hide resolved
content/en/serverless/azure_app_services/azure_app_services_linux.md
Outdated
Show resolved
Hide resolved
…Dog/documentation into topherc-dd/aas-code-sidecar-updates
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
dd-devflow
bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
What does this PR do? What is the motivation?
Adding documentation for the Azure app service sidecar method for code deployment. This will replaces the wrapper script that we told customers to previously use which that document has been moved to another page.
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes
Depending on formatting issues this is might be a WIP