Skip to content

Conversation

@nhulston
Copy link
Contributor

@nhulston nhulston commented Aug 7, 2025

What does this PR do? What is the motivation?

Add documentation about the service label and info bars linking to our GCP sample apps.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Aug 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

✅ Documentation Team Review

The documentation team has approved this pull request. Thank you for your contribution!

@nhulston nhulston force-pushed the nicholas.hulston/add-gcp-sample-apps-and-service-label branch from 6c7372d to 42090bd Compare August 7, 2025 20:23
@nhulston nhulston marked this pull request as ready for review August 7, 2025 21:30
@nhulston nhulston requested review from a team as code owners August 7, 2025 21:30
--update-env-vars=DD_SITE=$DD_SITE \
```

Finally, add a service label in Google Cloud. In your Cloud Run service's info panel, add a label with the following key and value:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this its own section 5 to highlight that this is something they must do (it might not hurt to say this is required since it is for the serverless UI to correlate the DD_SERVICE value to their integration metrics)

@nhulston
Copy link
Contributor Author

nhulston commented Aug 8, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Aug 8, 2025

View all feedbacks in Devflow UI.

2025-08-08 20:38:15 UTC ℹ️ Start processing command /merge


2025-08-08 20:38:22 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-08-09 00:39:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@cswatt
Copy link
Contributor

cswatt commented Aug 11, 2025

/merge

@cswatt cswatt merged commit 3b12390 into master Aug 11, 2025
22 of 25 checks passed
@cswatt cswatt deleted the nicholas.hulston/add-gcp-sample-apps-and-service-label branch August 11, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend mergequeue-status: removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants