-
Notifications
You must be signed in to change notification settings - Fork 1.2k
full_host: update documentation #31779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update full host documentation to: - align wording (replace Full Host with Full-Host for consistency) - remove irrelevant information (bottlenecks, tracer versions) - add support linux versions - remove build instructions - move and fix errata in debug symbols section
Preview links (active after the
|
janine-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! I made some really minor suggestions for readability and formatting 🙂
| 5. Run: | ||
|
|
||
| ``` | ||
| DD_BETA_COMMANDS_ENABLED=1 datadog-ci elf-symbols upload ~/your/build/bin/ | ||
| DD_BETA_COMMANDS_ENABLED=1 datadog-ci elf-symbols upload ~/your/build/symbols/ | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Annoyingly, I can't add a suggestion to this whole chunk. But this will look better if you can indent the code sample, so it's in line with "Run:`:
5. Run:
```
DD_BETA_COMMANDS_ENABLED=1 datadog-ci elf-symbols upload ~/your/build/bin/
DD_BETA_COMMANDS_ENABLED=1 datadog-ci elf-symbols upload ~/your/build/symbols/
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thank you 🙇 !
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
What does this PR do? What is the motivation?
Update full host documentation to:
Merge instructions
Merge readiness:
Additional notes
N/A