Skip to content

Conversation

@zafikrat
Copy link
Contributor

@zafikrat zafikrat commented Oct 7, 2025

https://datadoghq.atlassian.net/browse/AQG-404

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Preview links (active after the build_preview check completes)

Modified Files

@zafikrat zafikrat marked this pull request as ready for review October 7, 2025 07:40
@zafikrat zafikrat requested review from a team as code owners October 7, 2025 07:40
Copy link
Contributor

@git-thuerk-done git-thuerk-done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zafikrat looks good! Feel free to click the Squash and Merge button when this is ready to go.

Copy link
Contributor

@deigote deigote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few non-blocking nits:

  • FROM -> FROM (aligned w/ the rest of the doc)
  • It'd be nice to include an example
  • The form word strikes me as odd here, but maybe it has a motivation? otherwise I'd go with function.

@zafikrat
Copy link
Contributor Author

zafikrat commented Oct 9, 2025

A few non-blocking nits:

  • FROM -> FROM (aligned w/ the rest of the doc)
  • It'd be nice to include an example
  • The form word strikes me as odd here, but maybe it has a motivation? otherwise I'd go with function.

I’m not sure I fully understand the first point about FROM. For what it’s worth, we use similar wording for UNNEST, so I wanted to keep the phrasing consistent.

Regarding the example: this is covered by ticket AQG-330, which aims to handle the multiple missing occurrences.

@zafikrat zafikrat merged commit 85afc2b into master Oct 9, 2025
29 of 31 checks passed
@zafikrat zafikrat deleted the zakaria/add-json-array-elements branch October 9, 2025 07:16
@deigote
Copy link
Contributor

deigote commented Oct 9, 2025

Sorry, it seems something got lost in translation... that was supposed to be: FROM -> FROM (other keywords are marked as code in the docs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants