-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[DOCS-12260] Cloudcraft Azure support #32424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS-12260] Cloudcraft Azure support #32424
Conversation
Preview links (active after the
|
…:DataDog/documentation into aliciathuerk/DOCS-12260-Cloudcraft-Azure merge master
|
From the Cloudcraft team, this looks good. I'd just update this part: These diagrams visually represent AWS cloud resources, allowing you to explore and analyze your environments.I'd update it to include Azure instead of mentioning AWS only. |
Thanks @jamesponddotco good catch! Just merged that update. |
buraizu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but left a few suggestions and posted some questions.
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
|
Thanks @buraizu ! I incorporated your feedback in these 2 commits: |
buraizu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying that feedback! Just reiterated a previous suggestion with some additional context, and I also posted another question about the updated Azure steps
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
* adding Azure support and updating screenshots * updating permissions for Azure * fix TOC snafu * testing commit image * add info on group by and labels * adding back image * updating infra and obsverability images * update SDS image * vuln and ccm * small wording tweak * feedback from James' review * Apply suggestions from Bryce's review Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com> * incorporating feedback * fix spacing * Apply suggestions from code review Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com> * wording tweak --------- Co-authored-by: aliciascott <alicia.scott@datadoghq.com> Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
What does this PR do? What is the motivation?
Breaks out the prerequisites section into 2 tabs:
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes