Add KSM CR metrics #32716
Add KSM CR metrics #32716
Conversation
Preview links (active after the
|
bitomaxsp
force-pushed
the
dep/ksmcrm
branch
from
24a1a93 to
5b08797
Compare
|
|
||
| **Note**: This functionality requires Cluster Agent 7.63.0+ | ||
|
|
||
| It is possible to use the kubernetes_state_core check to collect custom resource metrics when running Cluster Agent. |
There was a problem hiding this comment.
maybe: The kubernetes_state_core check can be configured to collect custom resource metrics when running the Cluster Agent.
|
I've pushed some edits:
|
* Add KSM CR metrics * Fixes after review * Update configuration.md --------- Co-authored-by: cecilia saixue wat-kim <cecilia.watt@datadoghq.com>
sblumenthal
left a comment
sblumenthal
left a comment
There was a problem hiding this comment.
I have some (late) comments
| {{% /tab %}} | ||
| {{% tab "Datadog Operator" %}} | ||
|
|
||
| 1. Install the Datadog Operator with an option that grants the Datadog Agent permission to collect custom resources: |
There was a problem hiding this comment.
This should be updated to signify that it requires operator v1.20+
| group: "vpcresources.k8s.aws" | ||
| kind: "CNINode" | ||
| version: "v1alpha1" | ||
| resource: "cninode-pluralized" |
There was a problem hiding this comment.
What this field is / why it is needed / when it is needed could be explicitly called out somewhere here
| labelsFromPath: | ||
| crd_name: [metadata, name] | ||
| metrics: | ||
| - name: "eniconfig" |
There was a problem hiding this comment.
It is not clear in this doc that this would result in a metric named (I am assuming) kubernetes_state_customresource.eniconfig
The kubernetes_state_customresource prefix behavior should be called out somewhere in this doc
Likewise, the behavior when the a metricNamePrefix is specified should also be documented (it would result in a metric like kubernetes_state_customresource.<metricNamePrefix>_<metricName>
|
Follow up fixes were done here: #32753 |
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes