Skip to content

Conversation

@ZStriker19
Copy link
Contributor

@ZStriker19 ZStriker19 commented Nov 12, 2025

…erence currently

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

Editorial Review card (Cecilia): https://datadoghq.atlassian.net/browse/DOCS-12664

@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@Yun-Kim Yun-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom instrumentation snippet looks great, just some suggestions on the notes

@ZStriker19 ZStriker19 requested a review from cswatt November 13, 2025 14:27
@ZStriker19 ZStriker19 marked this pull request as ready for review November 13, 2025 16:00
@ZStriker19 ZStriker19 requested a review from a team as a code owner November 13, 2025 16:00
@estherk15 estherk15 self-assigned this Nov 13, 2025
@estherk15 estherk15 added the editorial review Waiting on a more in-depth review label Nov 13, 2025
@estherk15 estherk15 removed their assignment Nov 13, 2025
@cswatt
Copy link
Contributor

cswatt commented Nov 13, 2025

Pushed changes to:

  • Put the note in a yellow banner
  • Minor syntax/formatting edits

@ZStriker19 ZStriker19 merged commit c5e7a8d into master Nov 13, 2025
15 of 17 checks passed
@ZStriker19 ZStriker19 deleted the zachg/otel_custom_instrumentation_example branch November 13, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial review Waiting on a more in-depth review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants