Skip to content

Release 3.5 - v3.5.15-dd.1#5

Merged
aneesh1 merged 3 commits intorelease-3.5-dd-v3.5.15-dd.1from
aa/cherry-pick-v3.5.15-dd.1
Oct 15, 2024
Merged

Release 3.5 - v3.5.15-dd.1#5
aneesh1 merged 3 commits intorelease-3.5-dd-v3.5.15-dd.1from
aa/cherry-pick-v3.5.15-dd.1

Conversation

@aneesh1
Copy link
Copy Markdown

@aneesh1 aneesh1 commented Sep 24, 2024

CHANGELOG for details.

Also includes a fix to support multiple SAN URIs in TLS peer verification - a feature used in etcd-fabric.

@aneesh1 aneesh1 force-pushed the aa/cherry-pick-v3.5.15-dd.1 branch 2 times, most recently from c111916 to 3a5b637 Compare September 25, 2024 14:36
@aneesh1 aneesh1 marked this pull request as ready for review September 25, 2024 15:04
@aneesh1 aneesh1 requested a review from nyodas September 25, 2024 15:04
@aneesh1 aneesh1 force-pushed the release-3.5-dd-v3.5.15-dd.1 branch from 44e611b to 9a55333 Compare September 25, 2024 21:22
@aneesh1 aneesh1 force-pushed the aa/cherry-pick-v3.5.15-dd.1 branch 3 times, most recently from ce1550c to 282099b Compare September 25, 2024 21:30
Copy link
Copy Markdown
Member

@badouralix badouralix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm up to the few changes we need to make to follow-up on etcd-io#18160

I am not exactly sure how we ended up modifying the certs in the test fixtures, it can be reverted to make this pull request simpler, but otherwise it is only a minor inconvenience

Comment thread client/pkg/transport/listener.go Outdated
Comment thread server/etcdmain/config.go Outdated
Comment thread server/etcdmain/help.go Outdated
@aneesh1 aneesh1 force-pushed the aa/cherry-pick-v3.5.15-dd.1 branch 2 times, most recently from 881159b to 8331a03 Compare October 8, 2024 20:21
Comment thread client/pkg/transport/listener.go Outdated
badouralix and others added 3 commits October 9, 2024 12:50
Cherry-pick etcd-io#13445 manually because
the remote repository has been deleted, and add support for multiple
values for allowed client and peer URIs

Signed-off-by: Ayaz Badouraly <ayaz.badouraly@datadoghq.com>
@aneesh1 aneesh1 force-pushed the aa/cherry-pick-v3.5.15-dd.1 branch from 8331a03 to cffd9c0 Compare October 9, 2024 16:51
@aneesh1 aneesh1 requested a review from badouralix October 10, 2024 18:02
@aneesh1 aneesh1 merged commit 60ff6aa into release-3.5-dd-v3.5.15-dd.1 Oct 15, 2024
@aneesh1 aneesh1 mentioned this pull request Nov 20, 2024
@badouralix badouralix deleted the aa/cherry-pick-v3.5.15-dd.1 branch November 24, 2025 16:43
badouralix pushed a commit that referenced this pull request May 5, 2026
Vulnerability #1: GO-2026-4962
    Excessive memory allocation when decoding malicious SFNT in
    golang.org/x/image
  More info: https://pkg.go.dev/vuln/GO-2026-4962
  Module: golang.org/x/image
    Found in: golang.org/x/image@v0.38.0
    Fixed in: golang.org/x/image@v0.39.0
    Example traces found:
      #1: pkg/chart/heatmaps.go:232:10: chart.plotComparisonHeatMapGrid calls plot.Legend.Draw, which eventually calls sfnt.Font.GlyphAdvance
      #2: pkg/chart/heatmaps.go:232:10: chart.plotComparisonHeatMapGrid calls plot.Legend.Draw, which eventually calls sfnt.Font.GlyphIndex
      #3: pkg/chart/heatmaps.go:232:10: chart.plotComparisonHeatMapGrid calls plot.Legend.Draw, which eventually calls sfnt.Font.Kern
      #4: pkg/chart/heatmaps.go:232:10: chart.plotComparisonHeatMapGrid calls plot.Legend.Draw, which eventually calls sfnt.Font.LoadGlyph
      #5: pkg/chart/heatmaps.go:31:2: chart.init calls draw.init, which eventually calls sfnt.Parse

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants