Support sending logs to Datadog v2 endpoints.#48
Conversation
This PR is also adding a public variable containing current Gem version.
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
LGTM overall!
Although I realize there's one more change you need to make, and that wasn't originally tracked in your card: the v2 API will start returning 429 HTTP responses. When a 429 is received, the payload should be retried after a backoff period. Basically, handling 429s with a behavior that’s similar to 5xxs makes sense for now. No need to handle 429s differently between v1 and v2 endpoints, even though the current v1 API should not return 429s.
|
Thanks for the review @olivielpeau 🙇 I've addressed your feedback. |
olivielpeau
left a comment
olivielpeau
left a comment
There was a problem hiding this comment.
LGTM if you were able to test this e2e with a fluentd setup 👍
|
@olivielpeau yes I've successfully validated E2E. I'll create a short doc to reproduce the local setup. |
2 participants
What does this PR do?
Add support to send logs to Datadog v2 endpoints.
Additional Notes
This PR is also adding a public variable containing current Gem version.
CHANGELOG/version update are also done in this PR.