Sources container_id tag from kubernetes meta location#67
Merged
lukesteensen merged 1 commit intoJul 10, 2024
Merged
Conversation
lukesteensen
approved these changes
Jul 1, 2024
Contributor
lukesteensen
left a comment
lukesteensen
left a comment
There was a problem hiding this comment.
This looks reasonable to me. Thanks for the contribution @rlafferty!
Author
Awesome @lukesteensen - any idea if it will make it into the next release? |
Contributor
|
@rlafferty Yes, this will go into the next release. I am working on getting a few things sorted out internally and then will start the release process. Hopefully later this week. |
lukesteensen
added a commit
that referenced
this pull request
Jul 13, 2024
Signed-off-by: Luke Steensen <luke.steensen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Looks to resolve #66
Sources the
container_idtag from the default location the kubernetes input filter places thecontainer_idattribute (kubernetes.docker_id).Motivation
What inspired you to submit this pull request?
This will allow drillthrough from the kubernetes dashboard views in datadog (at the container level) to be able to easily find logs as its filtering/searching based on
container_id. This is useful for pods that have multiple containers and you'd like it filtered for a specific container.Additional Notes
Anything else we should know when reviewing?