Fix archive extraction bugs #647
Merged
Merged
Conversation
ikretz
approved these changes
Jan 9, 2026
Comment on lines
+135
to
+136
| attr = zip_info.external_attr >> 16 | ||
| file_type = attr & 0o170000 |
Contributor
There was a problem hiding this comment.
Might be worth factoring this out into a small utility function, since I think you compute this in two places.
Contributor
Author
There was a problem hiding this comment.
Do you think it worth it? sounds having a function to add a number
christophetd
pushed a commit
that referenced
this pull request
Apr 10, 2026
Fix archive extraction bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address several problems while dealing with packages.
It includes several validations for:
Side tasks:
Improves the documentation by adding a section on how environment variables can be used to alter the tool's behaviour