GCP-XXXX: Add GCP Onboarding Script to Integrations-Management#10
Conversation
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| print( | ||
| f"Workflow ID {workflow_id} has already been used. Please start a new workflow." | ||
| ) | ||
| exit(1) |
There was a problem hiding this comment.
🔴 High: Code Quality Violation
do not use exit() (...read more)
Use sys.exit() instead of exit(). Exit is a builtin and done mostly for the console. sys.exit() is done for program with a proper return argument (see documentation).
Learn More
| print( | ||
| f"Missing required environment variables: {', '.join(missing_environment_vars)}" | ||
| ) | ||
| exit(1) |
There was a problem hiding this comment.
🔴 High: Code Quality Violation
do not use exit() (...read more)
Use sys.exit() instead of exit(). Exit is a builtin and done mostly for the console. sys.exit() is done for program with a proper return argument (see documentation).
Learn More
| ensure_login() | ||
| except Exception: | ||
| print("You must be logged in to GCloud Shell to run this script.") | ||
| exit(1) |
There was a problem hiding this comment.
🔴 High: Code Quality Violation
do not use exit() (...read more)
Use sys.exit() instead of exit(). Exit is a builtin and done mostly for the console. sys.exit() is done for program with a proper return argument (see documentation).
Learn More
tedkahwaji
changed the title
2 participants
Summary
The following change adds the gcp onboarding script to this repo.
Moved From:
https://github.com/DataDog/experimental/tree/main/teams/gcp-integrations/onboarding