[AZINTS-3895] Trigger LFO script from quickstart#12
Conversation
|
✅ Code Quality ✅ Code Vulnerabilities ✅ Library Vulnerabilities 🎉 All green!🛠️ No new code quality issues 🔗 Commit SHA: 0a58d8a | Docs | Was this helpful? Give us feedback! |
gpalmz
left a comment
There was a problem hiding this comment.
Nit and question but LGTM
0090886 to
bd30404
Compare
bd30404 to
a3bc0fe
Compare
|
|
||
| def upsert_log_forwarder(config: dict, subscriptions: set[Subscription]): | ||
| log_forwarder_config = Configuration( | ||
| management_group_id="", #TODO(AZINTS-3935): Make this not required |
Yeah once I'm done with the launch blockers that is definitely something I want to do. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Summary
Add a step to the quickstart script to create or update the log forwarder. Since we already have a
log_forwardersstep to collect the existing log forwarders, I've named this oneupsert_log_forwarder. We perform this step only if we get a non-empty log forwarding config as part of the user selections.Since the LFO script wants scopes in terms of subscriptions only, we flatten management groups into subscriptions and dedup before passing them as part of the log forwarder config.
In order to invoke the script from this script, I've separated out the business logic from the command line arg parsing in the main function.
Testing
I made some temporary modifications for testing purposes:
Then connected the script and submitted with log forwarding enabled:

Note that the log forwarder settings came through and the loading text is correct.
Now try submitting with log forwarding disabled:

Note that we do not enter the step.