Skip to content

[azure] Bug fix + test cleanup#17

Merged
agulen merged 5 commits into
mainfrom
altan/2509/cpsubs
Sep 30, 2025
Merged

[azure] Bug fix + test cleanup#17
agulen merged 5 commits into
mainfrom
altan/2509/cpsubs

Conversation

@agulen
Copy link
Copy Markdown
Member

@agulen agulen commented Sep 30, 2025

Overview

Jira

I noticed a bug in my last PR where subscription ID and name were being returned in an array together in the JSON payload reported to the front end. These should not be in an array like this.
image

This is because these 2 values were previously stored in a dict[str,str] where id -> name, but were updated to a tuple[str,str]. Python converts tuples into lists during JSON encoding.

I updated the LfoControlPlane dataclass to have 2 explicit properties for sub_id and sub_name to avoid any confusion.

I also took some time to refactor + clean up a bunch of tests. I centralized a bunch of shared test data into test_data.py, further differentiated subscription IDs and subscription names in test data, and updated individual tests accordingly.

Testing

  • Unit tests passing
  • Manual test looks good
image

@agulen agulen requested a review from a team as a code owner September 30, 2025 15:55
@agulen agulen requested review from benjjs, gpalmz and pashneal and removed request for pashneal September 30, 2025 15:55
@agulen agulen merged commit 3087820 into main Sep 30, 2025
2 checks passed
@agulen agulen deleted the altan/2509/cpsubs branch September 30, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants