Skip to content

[azure][lfo] Enable expansion of log forwarding scopes#18

Merged
agulen merged 11 commits into
mainfrom
altan/2509/lfoexpandscopes
Oct 2, 2025
Merged

[azure][lfo] Enable expansion of log forwarding scopes#18
agulen merged 11 commits into
mainfrom
altan/2509/lfoexpandscopes

Conversation

@agulen
Copy link
Copy Markdown
Member

@agulen agulen commented Oct 1, 2025

Overview

AZINTS-3876

Currently, if a user sets up log forwarding through the new onboarding experience, they are stuck with whatever LFO settings they used on the initial setup. We need to enable users to edit their existing LFO configs. This enables users to update which subscriptions have log forwarding setup and the ability to update their tag filters & PII filtering rules post-deployment.

This PR accomplishes this through few different behaviors:

  • Enforcing a single LFO per Azure tenant - if multiple are found, the user is directed to uninstall extraneous ones
  • If a single LFO is found, we validate that the control plane parameters are the same as the new one being configured
  • There is an explicit code flow for creating a new LFO vs updating an existing one
  • Refactored shared code between the create and edit flows

Misc

  • Moved logging out of main and into its own file
  • Introduced a flag to skip the LFO singleton check for our own dev-testing - this will not be printed in usage seen by the user

Testing

  • Unit tests passing
  • Manual tests look good - you can see log count dropping after I updated the LFO to have different tag filters
image

@agulen agulen requested a review from a team as a code owner October 1, 2025 17:52
@agulen agulen requested review from pashneal and removed request for pashneal October 1, 2025 17:52
@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented Oct 1, 2025

⚠️ Code Quality    ✅ Code Vulnerabilities    ✅ Library Vulnerabilities

⚠️ Warnings

🛠️ 1 Code quality issue detected

Low: python-best-practices/comment-fixme-todo-ownership TODO and FIXME comments must have ownership View rule
azure/logging_install/src/azure_logging_install/validation.py:59

ℹ️ Info

🛡️ No new code vulnerabilities
📚 No new vulnerable libraries detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f06efdc | Docs | Was this helpful? Give us feedback!

Comment thread azure/logging_install/src/azure_logging_install/validation.py
@agulen agulen requested review from benjjs and gpalmz October 1, 2025 17:52
Comment thread azure/logging_install/src/azure_logging_install/validation.py
Copy link
Copy Markdown
Collaborator

@gpalmz gpalmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agulen agulen merged commit 77b5dd7 into main Oct 2, 2025
2 checks passed
@agulen agulen deleted the altan/2509/lfoexpandscopes branch October 2, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants