Add CONTROL_PLANE_REGION to common app settings#182
Merged
Conversation
All three control plane function apps (resource-task, diagnostic-settings-task, scaling-task) now receive CONTROL_PLANE_REGION via commonAppSettings, not just scaling-task. Mirrors the change across both deployment paths so they stay in lockstep: - ARM/Bicep (control_plane.bicep, dist/azuredeploy.json) - Python imperative installer (resource_setup.py) Rebuilt dist artifacts whose contents bundle logging_install/src: - logging_install/dist/azure_logging_install.pyz - integration_quickstart/dist/azure_app_registration_quickstart.pyz - integration_quickstart/dist/azure_log_forwarding_quickstart.pyz Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kendlelam680
force-pushed
the
kendle.lam/azure-control-plane-region-env
branch
from
6b60bfb to
d50ed51
Compare
mattsp1290
approved these changes
May 7, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All three LFO tasks currently use the
CONTROL_PLANE_REGIONenv var. The PR moves this into the common app settings shared by all three control plane function apps. Previously onlyscaling-taskgot it, so the other two function apps couldn't read their own region from env.Makes the change for the arm template and python installer.
azure/logging_install/bicep/control_plane.bicep: movedCONTROL_PLANE_REGION_SETTINGout ofscalingTask's app-specific settings intocommonAppSettings.azure/logging_install/src/azure_logging_install/resource_setup.py: movedCONTROL_PLANE_REGIONout of thescaling-taskbranch inset_function_app_env_varsintocommon_settings.