Pull out shared azure logic#33
Merged
Merged
Conversation
agulen
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I want to re-use
az_cmdin the quickstart script.Summary
Move
az_cmd.pyand its dependencies and test into a newsharedfolder. I've followed the same structure as the other sub-projects for consistency.This necessitated a bunch of updates to imports throughout
logging_install. It also meant that thelogging_installexecutable now must be built from more than one directory, which makes abuild.shscript necessary.Testing
Since tests now use code from across sub-projects, they should now be run from
azure.I've made sure both the moved test and the
logging_installtests are still passingpython -m pytest shared/tests/ --tb=shortpython -m pytest logging_install/tests/ --tb=short