[azure] Friendlier errors from log forwarding upsert#38
Merged
Conversation
benjjs
reviewed
Oct 17, 2025
| "python.analysis.autoSearchPaths": true, | ||
| "python.terminal.activateEnvironment": true | ||
| "python.terminal.activateEnvironment": true, | ||
| "python.languageServer": "Pylance" |
Collaborator
There was a problem hiding this comment.
Since we're doing format-on-save now I want to mess with the settings a bit (max length 80 hurts my eyes) but I can do that in a followup.
gpalmz
approved these changes
Oct 17, 2025
Collaborator
gpalmz
left a comment
gpalmz
left a comment
There was a problem hiding this comment.
Couple nitty things but non-blocking
| return set( | ||
| [s for s in scopes if isinstance(s, Subscription)] + | ||
| [s for subs in [m.subscriptions.subscriptions for m in scopes if isinstance(m, ManagementGroup)] for s in subs] | ||
| [s for s in scopes if isinstance(s, Subscription)] |
Collaborator
There was a problem hiding this comment.
What's the max line length with this formatter? Like 10 chars? 🤣
| except Exception as e: | ||
| raise AccessError("Azure CLI not authenticated. Run 'az login' first.") from e | ||
| raise AzCliNotAuthenticatedError( | ||
| "Azure CLI is not authenticated. Please run 'az login' first and retry" |
Collaborator
There was a problem hiding this comment.
Could this user the same error message as in setup.py? Also curious whether this error should be raised there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Jira
Display friendlier messages when errors occur during log forwarding existence check or upsert.