[AZINTS-4026] Make lfo collection step non-blocking#41
Merged
benjjs merged 1 commit intoOct 20, 2025
Merged
Conversation
gpalmz
approved these changes
Oct 20, 2025
Collaborator
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
benjamin.johnsonstaub@datadoghq.com cancelled this merge request build |
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Collaborator
Author
|
/merge -c |
|
View all feedbacks in Devflow UI.
|
dd-devflow
Bot
added
mergequeue-status: removed
and removed
mergequeue-status: in_progress
labels
benjjs
deleted the
benjamin.johnsonstaub/azints-4026/log-collection-not-blocking
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We don't need to block the rest of the flow when log forwarders can't be collected for whatever reason. As long as we're monitoring for error messages, it's fine to let the user proceed.
Summary
Add a new "required' flag on the report step context manager that defaults to true, and make the collect lfo step not required. When we hit an error in a step that isn't required, we still do all of the things we would normally do (report the error, stop showing the loading spinner, etc.) we just swallow the error at the end instead of re-raising it.
We'll need a change to the UI as well to show the error without blocking.
Testing
Introduce an error into the lfo collection step. Run the script. It successfully makes it past the lfo collection step
