Skip to content

Prevent error on 404 awaiting selections; simplify request error handling#55

Merged
gpalmz merged 2 commits into
mainfrom
gpalmz/azure-request-behavior-2
Oct 24, 2025
Merged

Prevent error on 404 awaiting selections; simplify request error handling#55
gpalmz merged 2 commits into
mainfrom
gpalmz/azure-request-behavior-2

Conversation

@gpalmz
Copy link
Copy Markdown
Collaborator

@gpalmz gpalmz commented Oct 24, 2025

  • Forgot to catch and retry on 404 awaiting user selections in previous PR. Fixed that here.
  • Also decided that the easiest and most informative error handling approach is to just use the urllib errors directly. We don't really get anything out of wrapping them, and it reduces both the information we have when dealing with the errors and the information that's surfaced in tracebacks. We can get a better result by using the raise ... from e construct. Here's an example of such a traceback. (This 404 case won't be raised for real, it was just easy to grab as an example):
Screenshot 2025-10-24 at 10 51 33 AM

@gpalmz gpalmz requested a review from agulen October 24, 2025 14:52
@gpalmz gpalmz requested a review from a team as a code owner October 24, 2025 14:52
@gpalmz gpalmz merged commit b1f2b70 into main Oct 24, 2025
2 checks passed
@gpalmz gpalmz deleted the gpalmz/azure-request-behavior-2 branch October 24, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants