[AZINTS-4086] Report token expiry as connection error#59
Merged
benjjs merged 3 commits intoOct 28, 2025
Conversation
gpalmz
approved these changes
Oct 28, 2025
| step_complete.set() | ||
| if loading_message_thread: | ||
| loading_message_thread.join() | ||
| if isinstance(e, RuntimeError) and self.EXPIRED_TOKEN_ERROR in repr(e): |
Collaborator
There was a problem hiding this comment.
Not loving the cloud shell specific error handling in the general status reporter but definitely not something to block on
Collaborator
Author
There was a problem hiding this comment.
I don't think this is cloud shell specific? The language just refers to the Azure CLI which is used in either case.
Collaborator
There was a problem hiding this comment.
Got it, thanks. I do think it would be nice to share a status reporter across clouds eventually since it'll be hitting the same collection of endpoints once we migrate. I'd envision the status reporter ideally as just a client for that API. We can figure this out later though
agulen
approved these changes
Oct 28, 2025
benjjs
deleted the
benjamin.johnsonstaub/azints-4077/shortcut-multi-lfo
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Altan ran into an issue where if you start the flow and then come back after a while (but before our normal time-out, the azure CLI token can expire, even in cloud shell. This leads to an error being thrown and not being handled nicely. We should handle this nicely because it's a situation outside of our control.
Summary
Regardless of what step we're in, check any errors to see if they are a CLI token expiration error. If they are, report it as a connection error instead so that the UI can suggest a refresh instead of indicating that something has failed unexpectedly and that the user should contact support.
Testing
Still working on getting a test for this, it takes a while.