[AZINTS-3609] Move quickstart script to new repo#6
Conversation
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| az( | ||
| f'ad app permission add --id "{app_registration.client_id}" --api {MS_GRAPH_API} --api-permissions {" ".join([f"{role}=Role" for role in roles])}' | ||
| ) | ||
| # TODO: |
There was a problem hiding this comment.
🟡 Low: Code Quality Violation
| # TODO: | |
| # TODO(<owner>): |
comments must have ownership (...read more)
When using TODO or FIXME, specify who write the annotation. It's a best practice to remind you who created the annotation and have potential context and information about this issue.
There was a problem hiding this comment.
@gpalmz do you remember when this comes up? Is it fixed or should we circle back on this before launch?
There was a problem hiding this comment.
I think we still need to circle back and just test all these scenarios. I don't know what the behavior of the command is tbh
|
I have some in-progress changes for python QoL since this will be a multi-project repo. Things like language server, mapping folder structure to test executions, etc. Will hold off on this until we chat with GCP and figure out what the shared model will look like |
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
What's the deal with the vscode settings in the root directory? I notice there's mention of azure in there. Any reason not to consolidate further?
There was a problem hiding this comment.
There is in the interpreter path, which it seems to me should possibly be different for azure and other clouds if, for example, the cloud cli tools require different python versions.
| az( | ||
| f'ad app permission add --id "{app_registration.client_id}" --api {MS_GRAPH_API} --api-permissions {" ".join([f"{role}=Role" for role in roles])}' | ||
| ) | ||
| # TODO: |
There was a problem hiding this comment.
🟡 Low: Code Quality Violation
| # TODO: | |
| # TODO(<owner>): |
comments must have ownership (...read more)
When using TODO or FIXME, specify who write the annotation. It's a best practice to remind you who created the annotation and have potential context and information about this issue.
benjjs
force-pushed
the
benjamin.johnsonstaub/azints-3609/setup-script-to-new-repo
branch
from
941a78e to
4acc567
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
Bot
deleted the
benjamin.johnsonstaub/azints-3609/setup-script-to-new-repo
branch
3 participants
Motivation
We had it on our list of launch blockers to move the setup script to a public repo. In addition, we need this to live in the same place as the LFO setup script since we will be hooking it into the quickstart script shortly.
Summary
I've simply copied the setup script into this repo and added a few pieces of boilerplate to get (almost) parity with
logging_install. For the folder and executable names, I've replaced the generic "setup" with "integration_quickstart" which seems a bit more descriptive.The README.md sticks very closely to the format established by
logging_install.I've changed the python environment name discussed in the READMEs and referenced in vscode settings to
azintegrationmanagementso that it can be shared across the azure setup projects in this repo. This is more convenient and also enforces that all azure setup projects should be runnable from the same environment.Likewise, I've moved the vscode settings up a directory for similar reasons. I considered keeping it in both places, but this creates multiple sources of truth.
Some notable things not done here that we should do at some point:
zipapping it anyway