Fix management group selection parsing#60
Merged
Conversation
gpalmz
approved these changes
Oct 28, 2025
Collaborator
gpalmz
left a comment
gpalmz
left a comment
There was a problem hiding this comment.
Looks like typescript except python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug with parsing management groups selected by the user. We weren't properly parsing the nested subscriptions. Now we are. This bug came up in our logs from early users.
Testing
Before: we can see that the
subscriptionsfield just contains a dictionaryAfter: we can see that the management group now has properly nested dataclasses under
subscriptions <img width="1997" height="92" alt="Screenshot 2025-10-28 at 3 00 44 PM" src="https://github.com/user-attachments/assets/c62be257-b24d-4741-968b-ce8c457fd967" /> I also ran theflatten_scopes` function that was previously failing on these scopes and it worked properly.