Skip to content

[azure][lfo] Auto-register missing resource providers#63

Merged
agulen merged 5 commits into
mainfrom
altan/2510/rpstatus
Oct 29, 2025
Merged

[azure][lfo] Auto-register missing resource providers#63
agulen merged 5 commits into
mainfrom
altan/2510/rpstatus

Conversation

@agulen
Copy link
Copy Markdown
Member

@agulen agulen commented Oct 29, 2025

Overview

AZINTS-4108

Current State

The LFO script validates that the necessary resource providers are already registered prior to setting up LFO resources. If one of the resource providers is unavailable, the script throws an error telling the user to register those resource providers and re-execute the script.

New State

The LFO script will collect the missing resource providers per subscription that the user configured for LFO and spin up threads in parallel to register the resource providers. Assuming that these registrations succeed, the script will proceed as usual.

I had previously written this feature using the async resource provider registration API, but the API to check the registration status was not very dependable. I realized there is a --wait flag that we can use on the registration command, so spinning up threads in our script with that proved to be better.

Testing

Manual happy path tests looking good - I am trying out some edge cases now.

@agulen agulen requested a review from a team as a code owner October 29, 2025 15:25
@agulen agulen requested review from benjjs and gpalmz October 29, 2025 15:25
@benjjs
Copy link
Copy Markdown
Collaborator

benjjs commented Oct 29, 2025

This can be a separate PR, but could we perform this validation while or after fetching existing LFOs in the quickstart script? Anything we can do before they make their selections is saving them time and improving their experience.

Copy link
Copy Markdown
Collaborator

@benjjs benjjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

@agulen
Copy link
Copy Markdown
Member Author

agulen commented Oct 29, 2025

This can be a separate PR, but could we perform this validation while or after fetching existing LFOs in the quickstart script? Anything we can do before they make their selections is saving them time and improving their experience.

I thought about this - the problem is that resource providers need to be registered per subscription. So we need to check these once the scope selections are locked in. But can be done.

@agulen agulen merged commit d75942e into main Oct 29, 2025
2 checks passed
@agulen agulen deleted the altan/2510/rpstatus branch October 29, 2025 16:37
@benjjs
Copy link
Copy Markdown
Collaborator

benjjs commented Oct 29, 2025

This can be a separate PR, but could we perform this validation while or after fetching existing LFOs in the quickstart script? Anything we can do before they make their selections is saving them time and improving their experience.

I thought about this - the problem is that resource providers need to be registered per subscription. So we need to check these once the scope selections are locked in. But can be done.

OK makes sense, we probably don't want to register the providers for all the subscriptions and that could take a long time anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants