AZINTS-4118 Surface user actionable errors#64
Merged
benjjs merged 3 commits intoOct 31, 2025
Merged
Conversation
agulen
reviewed
Oct 30, 2025
Member
agulen
left a comment
There was a problem hiding this comment.
lgtm, i'll do a pass over all the user actionable LFO errors to make sure we're showing user-friendly messages
agulen
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have some LFO errors that should be resolvable by the user. We should make these visible and easy to read in the UI.
Summary
Introduce a new status
USER_ACTIONABLE_ERRORfor errors that are user actionable. I feel comfortable not making this in some way a subtype of the ERROR status because we want to handle these quite differently.All user actionable errors that we're aware of currently exist in the LFO portion of the script, where Altan has made them subtypes of
UserActionRequiredError. When we catch an error in the step reporter, we first check if it is one of these. If so, we use the new status. We also use the simple string representation of the exception instead of a trace or rich representation, as the message to the user should be only the user-readable portion we include as the explicit error message.As a result, we may need a subsequent diff to update some error messages to be more complete and actionable. Ideally they should consist of 2 brief sentences:
I've also removed some error catching and re-raising logic in the LFO steps. This was nuking exception types, and shouldn't be necessary as the status reporter context manager itself adds some context to exceptions that are intended for our eyes.
Testing
See https://github.com/DataDog/web-ui/pull/243696